ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: deivid.rodriguez@riseup.net
To: ruby-core@ruby-lang.org
Subject: [ruby-core:91834] [Ruby trunk Bug#15582] default/bundler-1.17.2.gemspec has no file list
Date: Thu, 14 Mar 2019 17:21:50 +0000 (UTC)	[thread overview]
Message-ID: <redmine.journal-77104.20190314172149.74dc2423f07bc240@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-15582.20190201123952@ruby-lang.org

Issue #15582 has been updated by deivid (David Rodríguez).


Hi @hsbt!

I assumed this fix would also fix the incorrect file list for the etc gem's gemspec but I didn't try it and it looks like it didn't actually. On a the default ruby 2.6.2 release, the file list is  `["etc.so", "ext/etc/extconf.rb"]`. If I force reinstallation as a default gem, it becomes `[".gitignore".freeze, ".travis.yml".freeze, "Gemfile".freeze, "LICENSE.txt".freeze, "README.md".freeze, "Rakefile".freeze, "bin/console".freeze, "bin/setup".freeze, "etc.gemspec".freeze, "ext/etc/etc.c".freeze, "ext/etc/extconf.rb".freeze, "ext/etc/mkconstants.rb".freeze, "test/etc/test_etc.rb".freeze]`.

This causes some spec failures on bundler's test suite.

Thanks!

----------------------------------------
Bug #15582: default/bundler-1.17.2.gemspec has no file list
https://bugs.ruby-lang.org/issues/15582#change-77104

* Author: mame (Yusuke Endoh)
* Status: Closed
* Priority: Normal
* Assignee: hsbt (Hiroshi SHIBATA)
* Target version: 
* ruby -v: ruby 2.6.1p33 (2019-01-30 revision 66950) [x86_64-linux]
* Backport: 2.4: DONTNEED, 2.5: DONTNEED, 2.6: DONE
----------------------------------------
Ruby 2.6.1's *prefix*/lib/ruby/gems/2.6.0/specifications/default/bundler-1.17.2.gemspec seems wrong.

```
  s.files = ["bundler.rb".freeze, "exe/bundle".freeze, "exe/bundler".freeze]
```

It should have "bundler/setup.rb", "bundler/version.rb", etc.

This causes a trouble depending upon the order of `require` when a different version of bundler is installed:

```
$ gem list bundler

*** LOCAL GEMS ***

bundler (1.17.3, default: 1.17.2)

$ ruby -e 'require "bundler/version"; require "bundler"; p Bundler::VERSION'
"1.17.2"

$ ruby -e 'require "bundler"; require "bundler/version"; p Bundler::VERSION'
"1.17.3"
```

---Files--------------------------------
15582-bundler-gemspec.patch (5.17 KB)


-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>

      parent reply	other threads:[~2019-03-14 17:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <redmine.issue-15582.20190201123952@ruby-lang.org>
2019-02-01 12:39 ` [ruby-core:91374] [Ruby trunk Bug#15582] default/bundler-1.17.2.gemspec has no file list mame
2019-02-01 13:21 ` [ruby-core:91375] " hsbt
2019-02-01 13:23 ` [ruby-core:91376] " hsbt
2019-02-12  2:20 ` [ruby-core:91513] [Ruby trunk Bug#15582] default/bundler-1.17.2.gemspec has no filelist mame
2019-02-13 16:09 ` [ruby-core:91532] [Ruby trunk Bug#15582] default/bundler-1.17.2.gemspec has no file list deivid.rodriguez
2019-03-06  8:53 ` [ruby-core:91696] " naruse
2019-03-14 17:21 ` deivid.rodriguez [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-77104.20190314172149.74dc2423f07bc240@ruby-lang.org \
    --to=ruby-core@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).