From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 2B66920248 for ; Mon, 4 Mar 2019 11:53:04 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 39DE8121C4E; Mon, 4 Mar 2019 20:53:00 +0900 (JST) Received: from o1678916x28.outbound-mail.sendgrid.net (o1678916x28.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id F309D121C4A for ; Mon, 4 Mar 2019 20:52:57 +0900 (JST) Received: by filter0183p3mdw1.sendgrid.net with SMTP id filter0183p3mdw1-16399-5C7D1197-2B 2019-03-04 11:52:55.646582086 +0000 UTC m=+303851.405487255 Received: from herokuapp.com (unknown [34.229.211.113]) by ismtpd0018p1iad2.sendgrid.net (SG) with ESMTP id A94nAr8gQK-0I2Dc1KEUbw for ; Mon, 04 Mar 2019 11:52:55.571 +0000 (UTC) Date: Mon, 04 Mar 2019 11:52:56 +0000 (UTC) From: nobu@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 67110 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 15625 X-Redmine-Issue-Author: nelhage X-Redmine-Sender: nobu X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: =?us-ascii?Q?q8Dly+pU2+3ektTtZVXgZtbJPXwqo7p86jCsvYTW4Bwes8VXCwlYYNsT4EAnUY?= =?us-ascii?Q?M9r0KpGkR5bBIMUbTgmT8NmGHZQOa8HVIdm2+FO?= =?us-ascii?Q?irDeEYkR6npUhYOHYfD3aUVlQDhFsSrNL6234jR?= =?us-ascii?Q?MeuXAW1NRD2LqT8ucD1N6ijcE2ULv7JxfBzgiu8?= =?us-ascii?Q?MzCKDAUMCxk=2FkhLOvpKQlDnWpJNOHuUUVrg=3D=3D?= To: ruby-core@ruby-lang.org X-ML-Name: ruby-core X-Mail-Count: 91660 Subject: [ruby-core:91660] [Ruby trunk Bug#15625] Module#name performance has exponential-time worst case by aliased constants X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #15625 has been updated by nobu (Nobuyoshi Nakada). Subject changed from Module#name performance has exponential-time worst case to Module#name performance has exponential-time worst case by aliased constants File bug-15625.patch added Of course it is possible to check duplicated paths to refine worst cases, but it is a trade-off for usual case; no aliased constants. ### trunk | user| system| total| real ------+----------:|----------:|----------:|-----------: before| 2.117049| 0.003000| 2.120049|( 2.123071) a9 | 5.685656| 0.006082| 5.691738|( 5.697850) a10 | 9.309634| 0.013036| 9.322670|( 9.336729) a11 | 16.784519| 0.049488| 16.834007|( 16.883028) ### patched | user| system| total| real ------+----------:|----------:|----------:|-----------: before| 3.161939| 0.055769| 3.217708|( 3.223522) a9 | 3.317957| 0.046668| 3.364625|( 3.369195) a10 | 3.316404| 0.045762| 3.362166|( 3.366455) a11 | 3.321730| 0.048193| 3.369923|( 3.374927) ---------------------------------------- Bug #15625: Module#name performance has exponential-time worst case by aliased constants https://bugs.ruby-lang.org/issues/15625#change-76922 * Author: nelhage (Nelson Elhage) * Status: Open * Priority: Normal * Assignee: * Target version: * ruby -v: ruby 2.6.1p33 (2019-01-30 revision 66950) [x86_64-darwin18] * Backport: 2.4: UNKNOWN, 2.5: UNKNOWN, 2.6: UNKNOWN ---------------------------------------- It's well-known (c.f #11119) that `Module#name` has poor performance on anonymous classes, due to searching the entire constant namespace of the VM. However, we recently discovered that it's even worse than that. In the presence of aliased constants (e.g. `module M; end; Alias = M`), the `find_class_path` method actually searches every *path* to a given module (e.g. it will visit that module under both the `M` and `Alias` names). This can lead to exponential-time behavior in cases of repeated aliases. See the attached test case, where performance gets twice as slow with every additional layer of aliasing: On my laptop: ``` user system total real before 2.183899 0.012151 2.196050 ( 2.355187) user system total real a19 5.614596 0.024394 5.638990 ( 5.702878) user system total real a10 9.204399 0.052817 9.257216 ( 9.391010) user system total real a11 16.184035 0.060854 16.244889 ( 16.561101) ``` Our house style makes extensive use of aliases as an import-like mechanism to provide short names within a given scope. We discovered this bug while exploring an actual performance problem -- this is not just a theoretical report. ---Files-------------------------------- classname.rb (854 Bytes) bug-15625.patch (1.38 KB) -- https://bugs.ruby-lang.org/