From: s.wanabe@gmail.com
To: ruby-core@ruby-lang.org
Subject: [ruby-core:91648] [Ruby trunk Bug#15608] What should be the correct output for Method#inspect with singleton methods?
Date: Thu, 28 Feb 2019 23:49:37 +0000 (UTC) [thread overview]
Message-ID: <redmine.journal-76912.20190228234936.c2604fc9312e7fbd@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-15608.20190215164233@ruby-lang.org
Issue #15608 has been updated by wanabe (_ wanabe).
Current behavior is from r60127.
I guess it will come to the same to replace `data->klass` of `method_inspect()` to `data->iclass`.
----------------------------------------
Bug #15608: What should be the correct output for Method#inspect with singleton methods?
https://bugs.ruby-lang.org/issues/15608#change-76912
* Author: Eregon (Benoit Daloze)
* Status: Open
* Priority: Normal
* Assignee:
* Target version:
* ruby -v: ruby 2.6.1p33 (2019-01-30 revision 66950) [x86_64-linux]
* Backport: 2.4: UNKNOWN, 2.5: UNKNOWN, 2.6: UNKNOWN
----------------------------------------
bug.rb:
```ruby
class C
def foo
end
end
obj = C.new
class << obj
alias bar foo
end
p obj.method(:foo).owner
p obj.method(:foo)
raise unless obj.method(:foo).owner == C
p obj.method(:bar).owner
p obj.method(:bar)
raise unless obj.method(:bar).owner == obj.singleton_class
```
```
$ chruby 2.0.0
$ ruby -v bug.rb
ruby 2.0.0p648 (2015-12-16) [x86_64-linux]
C
#<Method: C#foo>
#<Class:#<C:0x0055b39fcd2c30>>
#<Method: C(C)#foo>
$ chruby 2.3.8
$ ruby -v bug.rb
ruby 2.3.8p459 (2018-10-18 revision 65136) [x86_64-linux]
C
#<Method: C#foo>
#<Class:#<C:0x000055668ebef268>>
#<Method: #<C:0x000055668ebef268>.bar(foo)>
$ chruby 2.4.5
$ ruby -v bug.rb
ruby 2.4.5p335 (2018-10-18 revision 65137) [x86_64-linux]
C
#<Method: #<C:0x000055fdc99dc908>.foo>
#<Class:#<C:0x000055fdc99dc908>>
#<Method: #<C:0x000055fdc99dc908>.bar(foo)>
Same for 2.5.3 and 2.6.1
```
I think Method#inspect should show on which Module the method is defined (`Method#owner`), and only singleton methods should be shown as `receiver.method`, so:
```
C
#<Method: C#foo>
#<Class:#<C:0x000055668ebef268>>
#<Method: #<C:0x000055668ebef268>.bar(foo)>
```
Which only Ruby 2.3 does interestingly.
---
What's the meaning of the `C1(C2)` notation?
It seems to show `"#{receiver.class}(#{owner})` or `"#{receiver.singleton_class if receiver has a sclass}` depending on the version:
```ruby
class D < C
end
d = D.new
p d.method(:foo)
d.singleton_class
p d.method(:foo)
```
```
2.0-2.3:
#<Method: D(C)#foo>
#<Method: D(C)#foo>
2.4-2.6:
#<Method: D(C)#foo>
#<Method: #<D:0x000055c12b45e218>.foo>
```
I think the Ruby 2.4+ behavior is confusing and incorrect here, the object shouldn't be shown if it's not a singleton method, and Method#inspect shouldn't change for a given method.
Do you agree what I describe should be the correct behavior?
Can we fix it then?
--
https://bugs.ruby-lang.org/
next prev parent reply other threads:[~2019-02-28 23:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <redmine.issue-15608.20190215164233@ruby-lang.org>
2019-02-15 16:42 ` [ruby-core:91570] [Ruby trunk Bug#15608] What should be the correct output for Method#inspect with singleton methods? eregontp
2019-02-15 16:50 ` [ruby-core:91571] " eregontp
2019-02-28 23:49 ` s.wanabe [this message]
2019-10-15 2:45 ` [ruby-core:95323] [Ruby master " merch-redmine
2019-10-15 5:21 ` [ruby-core:95325] " eregontp
2019-10-15 14:34 ` [ruby-core:95334] " merch-redmine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-76912.20190228234936.c2604fc9312e7fbd@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).