ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: ruby-core@marc-andre.ca
To: ruby-core@ruby-lang.org
Subject: [ruby-core:91474] [Ruby trunk Feature#15330] autoload_relative
Date: Thu, 07 Feb 2019 18:01:47 +0000 (UTC)	[thread overview]
Message-ID: <redmine.journal-76733.20190207180146.69da025c20ef32f8@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-15330.20181121234341@ruby-lang.org

Issue #15330 has been updated by marcandre (Marc-Andre Lafortune).


Matz, given the renewed support for `autoload`, would you please reconsider the addition of `autoload_relative`?

As a reminder, more than 75% of the top Ruby gems could benefit from that feature.

----------------------------------------
Feature #15330: autoload_relative
https://bugs.ruby-lang.org/issues/15330#change-76733

* Author: marcandre (Marc-Andre Lafortune)
* Status: Open
* Priority: Normal
* Assignee: matz (Yukihiro Matsumoto)
* Target version: 
----------------------------------------
I'd like to propose a way to autoload a constant using a relative path.

It could look like:

```
autoload_relative :MyConst, 'models/my_const'
```

My proposal raises two questions:

1) what's the future of `autoload`?

I believe that `autoload` has been there for years, it is used successfully and has no real alternative.

I looked at a sample of 430 top gems (took the 500 top ranked according to Libraries.io, removed those that I failed to process). The number of those gems that appear to use `autoload` at least once is 94 of those (22%).

The number of lines in the code where `autoload` is called can be quite big. The top 5 are:
vagrant: 235
yard: 206
ffaker: 155
aws-sdk: 152
rdoc: 92

This is a minimum bound, as some gems might be using loops, my processing would only detect the one place in the code with `autoload`.

2) are many autoladed paths relative?

My preliminary numbers indicate that of the 94 gems using autoload, at least 75 are autoloading some relative files. That's a lower bound, as my algorithm is pretty crude and will only count the simplest cases as being relative. An example of gem my algorithm does not detect is `yard`, because the author wrote a small method to map the relative paths to global paths (code here: https://github.com/lsegal/yard/blob/master/lib/yard/autoload.rb#L3 )

Of those where my processing detects the relative requires, a vast majority are relative. The average is that 94% of autoloaded files are relative and would benefit from `require_relative`

In summary: I am convinced that `autoload` should remain in Ruby indefinitely. `autoload_relative` would actually be more useful than `autoload`. Even if the future of `autoload` remains uncertain, I would recommend adding `autoload_relative`; if it is ever decided to actually remove `autoload`, removing `autoload_relative` would not really add to the (huge) burden of gem maintainers.



-- 
https://bugs.ruby-lang.org/

      parent reply	other threads:[~2019-02-07 18:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <redmine.issue-15330.20181121234341@ruby-lang.org>
2018-11-21 23:43 ` [ruby-core:89934] [Ruby trunk Feature#15330] autoload_relative ruby-core
2018-11-22  5:40 ` [ruby-core:89948] " shevegen
2018-11-23  8:32 ` [ruby-core:89998] " matz
2018-11-23 17:35 ` [ruby-core:90008] " eregontp
2018-11-23 18:15 ` [ruby-core:90011] " merch-redmine
2018-11-23 18:28 ` [ruby-core:90012] " rafaelmfranca
2018-11-23 20:31 ` [ruby-core:90015] " eregontp
2019-01-27 16:12 ` [ruby-core:91301] " Greg.mpls
2019-02-07 18:01 ` ruby-core [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-76733.20190207180146.69da025c20ef32f8@ruby-lang.org \
    --to=ruby-core@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).