From: eregontp@gmail.com
To: ruby-core@ruby-lang.org
Subject: [ruby-core:91443] [Ruby trunk Feature#15287] New TracePoint events to support loading features
Date: Wed, 06 Feb 2019 23:27:00 +0000 (UTC) [thread overview]
Message-ID: <redmine.journal-76702.20190206232659.65132758178c8619@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-15287.20181107051954@ruby-lang.org
Issue #15287 has been updated by Eregon (Benoit Daloze).
Eregon (Benoit Daloze) wrote:
> I wonder, what purpose do you envision for `instruction_sequence`?
> It is of course MRI-specific (as documented), so I'm not sure how one would use it on other Ruby implementations.
Actually, I think it is suboptimal to have MRI-specific methods returning MRI-specific types (RubyVM::...) in a portable class like TracePoint.
It means TracePoint cannot be supported completely on other Ruby implementations, because e.g., some method like TracePoint#instruction_sequence is MRI specific.
----------------------------------------
Feature #15287: New TracePoint events to support loading features
https://bugs.ruby-lang.org/issues/15287#change-76702
* Author: ko1 (Koichi Sasada)
* Status: Closed
* Priority: Normal
* Assignee: ko1 (Koichi Sasada)
* Target version: 2.6
----------------------------------------
# Abstract
I propose the following new TracePoint events:
* `loaded` (invoked after `require`/`load`)
* `method_added` (invoked after method definition)
# Background
Sometimes we need to hook loading iseq. For example, checking loading files and so on.
Also we want to know what kind of methods are defined.
For both purpose, we can use some hook methods such as `Module#method_added` and so on.
However, defining methods we can override this features.
So that if we have two tools/libraries using this feature, they can be conflicted.
# Proposal
Introduce new TracePoint events:
* `loaded` (invoked after `require`/`load`)
* `method_added` (invoked after method definition)
Also the following methods can be added:
* Active only `loaded` event:
* `TracePoint#loaded_feature` returns feature name.
* `TracePoint#loaded_iseq` returns `RubyVM::InstructionSequence` object (MRI only, internal feature)
# Optional proposal
Add `class_added` alias name for `class` event.
--
https://bugs.ruby-lang.org/
prev parent reply other threads:[~2019-02-06 23:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <redmine.issue-15287.20181107051954@ruby-lang.org>
2018-11-07 5:19 ` [ruby-core:89742] [Ruby trunk Feature#15287] New TracePoint events to support loading features ko1
2018-11-07 8:15 ` [ruby-core:89744] " shevegen
2018-11-22 8:02 ` [ruby-core:89959] " ko1
2018-12-05 7:24 ` [ruby-core:90302] " ko1
2018-12-10 7:36 ` [ruby-core:90401] " ko1
2018-12-10 13:38 ` [ruby-core:90405] " eregontp
2018-12-10 19:48 ` [ruby-core:90407] " tenderlove
2018-12-10 21:11 ` [ruby-core:90410] " ko1
2018-12-12 5:52 ` [ruby-core:90436] " ko1
2018-12-27 22:10 ` [ruby-core:90754] " eregontp
2019-02-06 23:27 ` eregontp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-76702.20190206232659.65132758178c8619@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).