From: naruse@airemix.jp
To: ruby-core@ruby-lang.org
Subject: [ruby-core:91149] [Ruby trunk Bug#15520] [patch] configure should refuse to build with jemalloc when headers are missing
Date: Thu, 17 Jan 2019 22:08:01 +0000 (UTC) [thread overview]
Message-ID: <redmine.journal-76380.20190117220759.e232b5eb10ee9b1f@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-15520.20190110040311@ruby-lang.org
Issue #15520 has been updated by naruse (Yui NARUSE).
Backport changed from 2.4: REQUIRED, 2.5: REQUIRED, 2.6: REQUIRED to 2.4: REQUIRED, 2.5: REQUIRED, 2.6: DONE
ruby_2_6 r66852 merged revision(s) 66779.
----------------------------------------
Bug #15520: [patch] configure should refuse to build with jemalloc when headers are missing
https://bugs.ruby-lang.org/issues/15520#change-76380
* Author: mistydemeo (Misty De Meo)
* Status: Closed
* Priority: Normal
* Assignee:
* Target version:
* ruby -v: ruby 2.7.0dev (2019-01-10 fix_jemalloc_i.. 66768) [x86_64-darwin18]
* Backport: 2.4: REQUIRED, 2.5: REQUIRED, 2.6: DONE
----------------------------------------
When the `--with-jemalloc` option is passed, the configure script will correctly fail with an error if the library is missing. However, if the library is present and headers are missing, configure will succeed and allow the build to proceed. The actual build is unlikely to succeed in this case since the functions won't be defined.
Steps to reproduce:
1. Install jemalloc.
2. Delete jemalloc's headers.
3. Run ./configure --with-jemalloc &&is make
Expected behaviour:
configure fails because the requested jemalloc's headers are missing
Actual behaviour:
configure succeeds. On macOS, the build then fails with the following:
~~~
compiling gc.c
gc.c:7955:12: error: implicit declaration of function 'malloc_usable_size' is invalid in C99
[-Werror,-Wimplicit-function-declaration]
return malloc_usable_size(ptr);
^
gc.c:7955:12: note: did you mean 'malloc_good_size'?
/Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/malloc/malloc.h:134:15: note:
'malloc_good_size' declared here
extern size_t malloc_good_size(size_t size);
^
1 error generated.
make: *** [gc.o] Error 1
~~~
The attached patch fixes this by ensuring that configure fails if `--with-jemalloc` is passed but the headers are missing in the same way that it will fail if the library is missing.
This patch is against trunk. I've also reproduced it in several previous versions of Ruby.
---Files--------------------------------
0001-configure-refuse-to-build-with-jemalloc-when-header-.patch (933 Bytes)
--
https://bugs.ruby-lang.org/
next prev parent reply other threads:[~2019-01-17 22:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <redmine.issue-15520.20190110040311@ruby-lang.org>
2019-01-10 4:03 ` [ruby-core:90964] [Ruby trunk Bug#15520] [patch] configure should refuse to build with jemalloc when headers are missing mistydemeo
2019-01-10 7:53 ` [ruby-core:90975] " shevegen
2019-01-10 23:40 ` [ruby-core:91008] " mistydemeo
2019-01-17 22:08 ` naruse [this message]
2019-03-13 0:06 ` [ruby-core:91803] " nagachika00
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-76380.20190117220759.e232b5eb10ee9b1f@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).