From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-3.1 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id BD716211B4 for ; Fri, 11 Jan 2019 11:05:41 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 5F4751216BC; Fri, 11 Jan 2019 20:05:38 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id 6113D12165D for ; Fri, 11 Jan 2019 20:05:36 +0900 (JST) Received: by filter0094p3mdw1.sendgrid.net with SMTP id filter0094p3mdw1-26792-5C38787C-50 2019-01-11 11:05:32.848061975 +0000 UTC m=+298455.333023823 Received: from herokuapp.com (ec2-3-85-21-215.compute-1.amazonaws.com [3.85.21.215]) by ismtpd0006p1iad2.sendgrid.net (SG) with ESMTP id gLrRrBD8QD-NGmleMmRm7A Fri, 11 Jan 2019 11:05:32.727 +0000 (UTC) Date: Fri, 11 Jan 2019 11:05:34 +0000 (UTC) From: shevegen@gmail.com To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 66454 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 14344 X-Redmine-Issue-Author: kddeisz X-Redmine-Sender: shevegen X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS5BVDY9roMIwNzR+NQmf2WJ5SN08umpEbrVXE whNByivwZKHEPWFFhPze9RxQoHWWhh0TToYJT3oMmGsM1XIWJdiHi52Z9fyf01E/F//t5OSqU0PgI4 8XKIsWeUpdZOeUKHt4XB0A49FzJjPzhnBzC3PAPpAEIh+fUJPH40ycCftw== X-ML-Name: ruby-core X-Mail-Count: 91018 Subject: [ruby-core:91018] [Ruby trunk Feature#14344] refine at class level X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #14344 has been updated by shevegen (Robert A. Heiler). I think that: using do refine Array do Is not good. It looks very strange to me. The other variants, such as the original one: class Test refine String do or just toplevel: refine String do would seem better to me. It may be best to have matz pick a syntax, if he agrees with the feature. :) (May have to then also update documentation and specification of refinements; I remember that I was once surprised thinking that I knew the original definition but upon re-reading it, I realized that my assumption was not completely correct.) (On a side note, I think you added it to the recent developer meeting which already happened; may have to add it to the next one or just have it be a carry-over to the next meeting.) ---------------------------------------- Feature #14344: refine at class level https://bugs.ruby-lang.org/issues/14344#change-76243 * Author: kddeisz (Kevin Deisz) * Status: Open * Priority: Normal * Assignee: * Target version: ---------------------------------------- I rely on refinements a lot, but don't want to keep writing `Module.new` in code. I'm proposing `Object::refine`, which would create an anonymous module behind the scenes with equivalent functionality. So: ~~~ ruby class Test using Module.new { refine String do def refined? true end end } end ~~~ would become ~~~ ruby class Test refine String do def refined? true end end end ~~~ It's a small change, but reads a lot more clearly. Thoughts? -- https://bugs.ruby-lang.org/