ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: muraken@gmail.com
To: ruby-core@ruby-lang.org
Subject: [ruby-core:90942] [Ruby trunk Bug#15518] good old Infinite range notation behavior
Date: Wed, 09 Jan 2019 09:35:01 +0000 (UTC)	[thread overview]
Message-ID: <redmine.journal-76144.20190109093459.ae0dd6b5327494d7@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-15518.20190109054414@ruby-lang.org

Issue #15518 has been updated by mrkn (Kenta Murata).


At first, it isn't intentional behavior change. I should fix it, but I need to consider what is the correct behavior.

Ruby 2.5's behavior is given below:

```
$ RBENV_VERSION=2.5 irb --simple-prompt
>> (1 .. 10).first(5)
=> [1, 2, 3, 4, 5]
>> (1 .. 10.0).first(5)
=> [1, 2, 3, 4, 5]
>> (1.0 .. 10).first(5)
Traceback (most recent call last):
        4: from /Users/mrkn/.rbenv/versions/2.5/bin/irb:11:in `<main>'
        3: from (irb):3
        2: from (irb):3:in `first'
        1: from (irb):3:in `each'
TypeError (can't iterate from Float)
>> (1 .. 10r).first(5)
=> [1, 2, 3, 4, 5]
>> (1r .. 10).first(5)
Traceback (most recent call last):
        4: from /Users/mrkn/.rbenv/versions/2.5/bin/irb:11:in `<main>'
        3: from (irb):2
        2: from (irb):2:in `first'
        1: from (irb):2:in `each'
TypeError (can't iterate from Rational)
>> (1 .. 10).step(1).first(5)
=> [1, 2, 3, 4, 5]
>> (1 .. 10.0).step(1).first(5)
=> [1.0, 2.0, 3.0, 4.0, 5.0]
>> (1.0 .. 10).step(1).first(5)
=> [1.0, 2.0, 3.0, 4.0, 5.0]
>> (1 .. 10).step(1.0).first(5)
=> [1.0, 2.0, 3.0, 4.0, 5.0]
>> (1 .. 10r).step(1).first(5)
=> [1, 2, 3, 4, 5]
>> (1r .. 10).step(1).first(5)
=> [(1/1), (2/1), (3/1), (4/1), (5/1)]
>> (1 .. 10).step(1r).first(5)
=> [1, (2/1), (3/1), (4/1), (5/1)]
```

As you can see, the enumerator from Range#step is different from Range#each.
And, on Range#step, the result of the range with float components consists of Float values only while the result of the range with rational components does not.
The reason for this difference is that Range#step has the specialized implementation for the range with float components.

----------------------------------------
Bug #15518: good old Infinite range notation behavior
https://bugs.ruby-lang.org/issues/15518#change-76144

* Author: sakuro (Sakuro OZAWA)
* Status: Assigned
* Priority: Normal
* Assignee: mrkn (Kenta Murata)
* Target version: 
* ruby -v: ruby 2.6.0p0 (2018-12-25 revision 66547) [x86_64-darwin18]
* Backport: 2.4: UNKNOWN, 2.5: UNKNOWN, 2.6: UNKNOWN
----------------------------------------
Ruby 2.5.3's behavior

~~~
# without step, it produces integer sequence
(1..Float::INFINITY).first(10) #=> [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
# with step, it produces floats instead of integers
(1..Float::INFINITY).step(1).first(10) #=> [1.0, 2.0, 3.0, 4.0, 5.0, 6.0, 7.0, 8.0, 9.0, 10.0]
~~~

Ruby 2.6.0's behavior

~~~
# endless range
(1..).first(10) #=> [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
# with step, all numbers are integer now
(1..).step(1).first(10) #=> [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]

# old idiom with Float::INFINITY
(1..Float::INFINITY).first(10) #=> [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
(1..Float::INFINITY).step(1).first(10) #=> FloatDomainError (Infinity)
~~~

Which are intended change and which are not?




-- 
https://bugs.ruby-lang.org/

  parent reply	other threads:[~2019-01-09  9:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <redmine.issue-15518.20190109054414@ruby-lang.org>
2019-01-09  5:44 ` [ruby-core:90937] [Ruby trunk Bug#15518] good old Infinite range notation behavior sakuro+ruby-lang.org
2019-01-09  7:19 ` [ruby-core:90940] " sawadatsuyoshi
2019-01-09  8:34 ` [ruby-core:90941] [Ruby trunk Bug#15518][Assigned] " muraken
2019-01-09  9:35 ` muraken [this message]
2019-01-30  6:16 ` [ruby-core:91330] [Ruby trunk Bug#15518] " muraken
2019-01-30  6:20 ` [ruby-core:91331] " naruse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-76144.20190109093459.ae0dd6b5327494d7@ruby-lang.org \
    --to=ruby-core@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).