From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-3.1 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 87A161F803 for ; Mon, 7 Jan 2019 16:14:44 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id C42E412196D; Tue, 8 Jan 2019 01:14:40 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id 7E0651211D1 for ; Tue, 8 Jan 2019 01:14:38 +0900 (JST) Received: by filter0095p3iad2.sendgrid.net with SMTP id filter0095p3iad2-10742-5C337AE9-42 2019-01-07 16:14:33.992751715 +0000 UTC m=+313819.735185351 Received: from herokuapp.com (ec2-54-211-5-49.compute-1.amazonaws.com [54.211.5.49]) by ismtpd0044p1iad1.sendgrid.net (SG) with ESMTP id X0gafgqKRfqoMuIQZgfFYA for ; Mon, 07 Jan 2019 16:14:33.756 +0000 (UTC) Date: Mon, 07 Jan 2019 16:14:34 +0000 (UTC) From: nardonykolyszyn@gmail.com To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 66346 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 15515 X-Redmine-Issue-Author: lugray X-Redmine-Sender: devpolish X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS7x8rHQAu7FAp5AXSl62/0p4udcUE7sezHhxC lkJz28gX3dPQfHGnGLiX8N/RLMVRMNFgEuSDDr+9OmRRR3EE1u2gJFQrElVDu8DBIqU6tjan7I2626 NG4p+JZJ7Q84lVPKt9EImdqkNXK3bPy1GQfNgQGM615UFeDiUaUlNr9sdg== X-ML-Name: ruby-core X-Mail-Count: 90919 Subject: [ruby-core:90919] [Ruby trunk Bug#15515] OpenStruct raising NoMethodError instead of ArgumentError X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #15515 has been updated by devpolish (Nardo Nykolyszyn). Did you mean? OpenStruct ---------------------------------------- Bug #15515: OpenStruct raising NoMethodError instead of ArgumentError https://bugs.ruby-lang.org/issues/15515#change-76111 * Author: lugray (Lisa Ugray) * Status: Open * Priority: Normal * Assignee: * Target version: * ruby -v: ruby 2.7.0dev (2019-01-07 trunk 66747) [x86_64-darwin18] * Backport: 2.4: UNKNOWN, 2.5: UNKNOWN, 2.6: UNKNOWN ---------------------------------------- When an `OpenStruct` has some attribute `foo`, calling the `foo` method with an argument gives a no method error: ```ruby foo = OpenStuct.new(bar: 'baz') foo.bar(0) # => NoMethodError (undefined method `bar' for #) ``` This is confusing, since `foo.respond_to?(:bar) # => true`. I would expect: ```ruby foo = OpenStuct.new(bar: 'baz') foo.bar(0) # => ArgumentError (wrong number of arguments (given 1, expected 0)) ``` The included fixes this, and adjusts the arity `ArgumentError` for the setter to be in line with the default arity messaging too. ---Files-------------------------------- 0001-ostruct.rb-refine-arity-failure-message.patch (1.26 KB) 0001-ostruct.rb-refine-arity-failure-message.patch (1.96 KB) -- https://bugs.ruby-lang.org/