ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: justin@presidentbeef.com
To: ruby-core@ruby-lang.org
Subject: [ruby-core:90858] [Ruby trunk Bug#8028] Shellwords.escape works incorrect under windows
Date: Wed, 02 Jan 2019 17:00:45 +0000 (UTC)	[thread overview]
Message-ID: <redmine.journal-76044.20190102170043.7c15a34acae824a7@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-8028.20130306173140@ruby-lang.org

Issue #8028 has been updated by jsc (Justin Collins).


Shagabutdinov (Leonid Shagabutdinov) wrote:
> Shellwords.escape works incorrect under windows (tested for Windows 7

I don't believe `Shellwords` is intended to work on Windows at all. According to the comments (https://github.com/ruby/ruby/blob/ee2ddf5411f51ea89a1569ea5d70b41cd4c6c7f2/lib/shellwords.rb#L3-L6):

~~~
# == Manipulates strings like the UNIX Bourne shell
#
# This module manipulates strings according to the word parsing rules
# of the UNIX Bourne shell.
~~~



----------------------------------------
Bug #8028: Shellwords.escape works incorrect under windows
https://bugs.ruby-lang.org/issues/8028#change-76044

* Author: Shagabutdinov (Leonid Shagabutdinov)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: ruby 2.0.0p0 (2013-02-24) [i386-mingw32]
* Backport: 2.4: UNKNOWN, 2.5: UNKNOWN, 2.6: UNKNOWN
----------------------------------------
Shellwords.escape works incorrect under windows (tested for Windows 7
x64), here is example:


Actual result:

irb(main):001:0> require 'shellwords'
=> true

irb(main):002:0> `echo #{Shellwords.escape( '123>' )} test` # should
echo "123> test", but echo nothing
=> ""

irb(main):003:0> File.read( 'test' ) # but writes file "test"
=> "123\\\n"


Expected result:

irb(main):001:0> `echo 132^> test` # the correct escape sequence, echoed
"123> test"
=> "132> test\n"


Tested for "ruby 2.0.0p0 (2013-02-24) [i386-mingw32]", ruby 1.9.3, but this bug can be found in earlier ruby versions as well.





-- 
https://bugs.ruby-lang.org/

  reply	other threads:[~2019-01-02 17:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-06  8:31 [ruby-core:53162] [ruby-trunk - Bug #8028][Open] Shellwords.escape works incorrect under windows Shagabutdinov (Leonid Shagabutdinov)
2019-01-02 17:00 ` justin [this message]
2019-01-03 14:03 ` [ruby-core:90871] [Ruby trunk Bug#8028][Rejected] " nobu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-76044.20190102170043.7c15a34acae824a7@ruby-lang.org \
    --to=ruby-core@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).