From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-3.0 required=3.0 tests=AWL,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id DF2921F45B for ; Fri, 28 Dec 2018 19:04:25 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 2C923114B09; Sat, 29 Dec 2018 04:04:23 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id 5E8BD114B02 for ; Sat, 29 Dec 2018 04:04:21 +0900 (JST) Received: by filter0031p3las1.sendgrid.net with SMTP id filter0031p3las1-21027-5C2673AF-4C 2018-12-28 19:04:15.959580474 +0000 UTC m=+679928.401433086 Received: from herokuapp.com (ec2-54-242-89-103.compute-1.amazonaws.com [54.242.89.103]) by ismtpd0019p1iad2.sendgrid.net (SG) with ESMTP id YidyG7qWR4KgI88ez3K3ug Fri, 28 Dec 2018 19:04:15.856 +0000 (UTC) Date: Fri, 28 Dec 2018 19:04:17 +0000 (UTC) From: eregontp@gmail.com To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 66199 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 13570 X-Redmine-Issue-Author: Eregon X-Redmine-Issue-Assignee: X-Redmine-Sender: Eregon X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS5lXnZWixl6Le3eWtB6E/rGNvi1FoFJahZewD iOAfiXxfEkiA0a+7XRcxhyuZcX50Fd9Hjsno3MJzln/VR6VVY6ppaptX9c5rx9+10L81rbvjHnkVun P3Z2dx3bZpqIEGIjVAwBAVLPfXS+vBhSRXKADaW3SlPrA4q0IieO15Yqkg== X-ML-Name: ruby-core X-Mail-Count: 90779 Subject: [ruby-core:90779] [Ruby trunk Feature#13570] Using mkmf for ruby/spec C API specs X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #13570 has been updated by Eregon (Benoit Daloze). @nobu cherry-picked the IO.copy_stream patch in r66147, and I now upstreamed it to ruby/mspec. I mostly forgot about it, and it's easy enough for early Ruby implementations to shim IO.copy_stream. ---------------------------------------- Feature #13570: Using mkmf for ruby/spec C API specs https://bugs.ruby-lang.org/issues/13570#change-75954 * Author: Eregon (Benoit Daloze) * Status: Closed * Priority: Normal * Assignee: cruby-windows * Target version: ---------------------------------------- Hello all, I am thinking to use mkmf to compile the C API specs. https://github.com/ruby/ruby/blob/trunk/spec/rubyspec/optional/capi/spec_helper.rb is getting pretty complex and hard to maintain. I have a few questions: * Does mkmf works well on Windows? * What is a good way to compile a single .c file with mkmf to a given library file in another directory? I tried this but I am not sure it's correct: ~~~ ruby def compile_extension(name) objdir = object_path ext = "#{name}_spec" lib = "#{objdir}/#{ext}.#{RbConfig::CONFIG['DLEXT']}" require 'mkmf' # TODO: probably best to use a subprocess to avoid polluting the namespace Dir.chdir(objdir) do $srcs = ["#{extension_path}/#{ext}.c"] $objs = ["#{extension_path}/#{ext}.o"] # should probably be in objdir but that does not seem to work create_makefile(ext) system "make" end lib end ~~~ Alternatively, we can copy the needed files to a temporary directory, build there and copy the shared library back. It's a bit more work but not a big deal either. ---Files-------------------------------- spec_helper.rb (2.22 KB) spec_helper.rb (2.24 KB) -- https://bugs.ruby-lang.org/