From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-3.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 3EC1220A1E for ; Fri, 14 Dec 2018 19:51:48 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 664CD120BE3; Sat, 15 Dec 2018 04:51:45 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id 7FE23120BB1 for ; Sat, 15 Dec 2018 04:51:42 +0900 (JST) Received: by filter0193p3mdw1.sendgrid.net with SMTP id filter0193p3mdw1-24513-5C1409C9-28 2018-12-14 19:51:37.501425887 +0000 UTC m=+916.290863107 Received: from herokuapp.com (ec2-54-205-142-45.compute-1.amazonaws.com [54.205.142.45]) by ismtpd0012p1iad2.sendgrid.net (SG) with ESMTP id 4QK6V03HSr6A1hS3RfdIoQ Fri, 14 Dec 2018 19:51:37.394 +0000 (UTC) Date: Fri, 14 Dec 2018 19:51:38 +0000 (UTC) From: nardonykolyszyn@gmail.com To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 65935 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 15393 X-Redmine-Issue-Author: tenderlovemaking X-Redmine-Sender: devpolish X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS6WLO1E/pOxI7EaWlTpgZFLsjrDvu0pY94J/q bJv1jOYPGgPlyzfWnatUniN+1VaZjVHaCSAiuXVMYrkC50ldXXcFxNteXDswSZEY4Tr0XyyWj85Z8E Gss81wAD63nZh7QsCMP0uK1r3V6jJLaAfFty6T1MC5/U7RkDwFIVdHFnXg== X-ML-Name: ruby-core X-Mail-Count: 90530 Subject: [ruby-core:90530] [Ruby trunk Feature#15393] Add compilation flags to freeze Array and Hash literals X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #15393 has been updated by devpolish (Nardo Nykolyszyn). I've been waiting this for a while. I'm completely agree. ---------------------------------------- Feature #15393: Add compilation flags to freeze Array and Hash literals https://bugs.ruby-lang.org/issues/15393#change-75684 * Author: tenderlovemaking (Aaron Patterson) * Status: Open * Priority: Normal * Assignee: * Target version: ---------------------------------------- Hi, I would like to add VM compilation options to freeze array and hash literals. For example: ~~~ ruby frozen = RubyVM::InstructionSequence.compile(<<-eocode, __FILE__, nil, 0, frozen_string_literal: true, frozen_hash_and_array_literal: true) { 'a' => ['b', { 'c' => 'd' }] } eocode puts frozen.disasm ~~~ Output is: ~~~ $ ./ruby thing.rb == disasm: #@thing.rb:0 (0,0)-(0,34)> (catch: FALSE) 0000 putobject {"a"=>["b", {"c"=>"d"}]} 0002 leave ~~~ Anything nested in the hash that can't be "frozen" will cause it to not be frozen. For example: ~~~ ruby not_frozen = RubyVM::InstructionSequence.compile(<<-eocode, __FILE__, nil, 0, frozen_string_literal: true, frozen_hash_and_array_literal: true) { 'a' => some_method } eocode puts not_frozen.disasm ~~~ Output: ~~~ $ ./ruby thing.rb == disasm: #@thing.rb:0 (0,0)-(0,24)> (catch: FALSE) 0000 putobject "a" 0002 putself 0003 opt_send_without_block , 0006 newhash 2 0008 leave ~~~ Eventually I would like to freeze array and hash literals in source code itself, but I think this is a good first step. The reason I want this feature is I think we can reduce some object allocations, and once Guilds are implemented, easily create immutable data. I've attached a patch that implements the above. (Also I think maybe "frozen_literals" would be a better name, but I don't want to imply that numbers or booleans are frozen too) Thanks! ---Files-------------------------------- 0001-Add-compile-options-for-freezing-hash-and-array-lite.patch (6.14 KB) -- https://bugs.ruby-lang.org/