From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-1.6 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,RCVD_IN_DNSWL_MED,SPF_PASS shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id A8F0120A1E for ; Thu, 13 Dec 2018 08:47:43 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id B5446120FA8; Thu, 13 Dec 2018 17:47:41 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id E1FC1120F9D for ; Thu, 13 Dec 2018 17:47:38 +0900 (JST) Received: by filter0110p3las1.sendgrid.net with SMTP id filter0110p3las1-4644-5C121CA7-22 2018-12-13 08:47:35.613163909 +0000 UTC m=+113799.953711725 Received: from herokuapp.com (ec2-54-211-146-162.compute-1.amazonaws.com [54.211.146.162]) by ismtpd0011p1iad2.sendgrid.net (SG) with ESMTP id Abrk3zmdSBm9hHbtT-iVeg Thu, 13 Dec 2018 08:47:35.494 +0000 (UTC) Date: Thu, 13 Dec 2018 08:47:36 +0000 (UTC) From: janfri26@gmail.com To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 65907 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 15393 X-Redmine-Issue-Author: tenderlovemaking X-Redmine-Sender: janfri X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS6QWTAvi3RcZbXmEdUiLOLQMfmyc22dpuMRWs XuIiFmCrTm32dQEl2EEesbx8zskh9/p7oWWF/74ZV9uCvNnW158HocBbcQk+At47vC9n4Pe+rq15NM K3rd9w2tNrKy7UlmYsrERaHYM5GwBT+nMGQZLBEHxvGoPdbm2rPkuObYIw== X-ML-Name: ruby-core X-Mail-Count: 90500 Subject: [ruby-core:90500] [Ruby trunk Feature#15393] Add compilation flags to freeze Array and Hash literals X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #15393 has been updated by janfri (Jan Friedrich). shan (Shannon Skipper) wrote: > I had the same thought as shevy, that it'd be nice to have a: > > ~~~ ruby > # frozen_literals: true > ~~~ > > It might also be worth considering a separate `frozen_array_literal` and `frozen_hash_literal`. I have files where I'd initially only want to enable one of the above. +1 ---------------------------------------- Feature #15393: Add compilation flags to freeze Array and Hash literals https://bugs.ruby-lang.org/issues/15393#change-75657 * Author: tenderlovemaking (Aaron Patterson) * Status: Open * Priority: Normal * Assignee: * Target version: ---------------------------------------- Hi, I would like to add VM compilation options to freeze array and hash literals. For example: ~~~ ruby frozen = RubyVM::InstructionSequence.compile(<<-eocode, __FILE__, nil, 0, frozen_string_literal: true, frozen_hash_and_array_literal: true) { 'a' => ['b', { 'c' => 'd' }] } eocode puts frozen.disasm ~~~ Output is: ~~~ $ ./ruby thing.rb == disasm: #@thing.rb:0 (0,0)-(0,34)> (catch: FALSE) 0000 putobject {"a"=>["b", {"c"=>"d"}]} 0002 leave ~~~ Anything nested in the hash that can't be "frozen" will cause it to not be frozen. For example: ~~~ ruby not_frozen = RubyVM::InstructionSequence.compile(<<-eocode, __FILE__, nil, 0, frozen_string_literal: true, frozen_hash_and_array_literal: true) { 'a' => some_method } eocode puts not_frozen.disasm ~~~ Output: ~~~ $ ./ruby thing.rb == disasm: #@thing.rb:0 (0,0)-(0,24)> (catch: FALSE) 0000 putobject "a" 0002 putself 0003 opt_send_without_block , 0006 newhash 2 0008 leave ~~~ Eventually I would like to freeze array and hash literals in source code itself, but I think this is a good first step. The reason I want this feature is I think we can reduce some object allocations, and once Guilds are implemented, easily create immutable data. I've attached a patch that implements the above. (Also I think maybe "frozen_literals" would be a better name, but I don't want to imply that numbers or booleans are frozen too) Thanks! ---Files-------------------------------- 0001-Add-compile-options-for-freezing-hash-and-array-lite.patch (6.14 KB) -- https://bugs.ruby-lang.org/