From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 347C820A1E for ; Mon, 10 Dec 2018 19:48:49 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id CF508120AE1; Tue, 11 Dec 2018 04:48:43 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id E9D63120A71 for ; Tue, 11 Dec 2018 04:48:40 +0900 (JST) Received: by filter0040p3iad2.sendgrid.net with SMTP id filter0040p3iad2-22276-5C0EC314-25 2018-12-10 19:48:36.429279377 +0000 UTC m=+50080.470322560 Received: from herokuapp.com (ec2-54-166-30-52.compute-1.amazonaws.com [54.166.30.52]) by ismtpd0024p1mdw1.sendgrid.net (SG) with ESMTP id aNN4Ix1nQAyZkTsqcAZWmw for ; Mon, 10 Dec 2018 19:48:36.360 +0000 (UTC) Date: Mon, 10 Dec 2018 19:48:37 +0000 (UTC) From: tenderlove@ruby-lang.org To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 65806 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 15287 X-Redmine-Issue-Author: ko1 X-Redmine-Issue-Assignee: ko1 X-Redmine-Sender: tenderlovemaking X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS4qDRUoSCXzGT3k9gyspSCmOaoNFMXYzx1yYt kxIQRBFW0S4riwPCh9eu/7FkH6bK6/pTRJS8wXSAWI131qaSRJKPBS9SbYimx6vL4YR3s0lnysL0Kz mdRE1w6Wx20Hs+MOGl7yDP+BlJr4kowKT+Vwk1Q2jzWXaRi0A+p7QHReNw== X-ML-Name: ruby-core X-Mail-Count: 90407 Subject: [ruby-core:90407] [Ruby trunk Feature#15287] New TracePoint events to support loading features X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #15287 has been updated by tenderlovemaking (Aaron Patterson). I agree with @eregon. The user has to subscribe to the "compiled_script" event, so the fact that the script has been compiled is already known. For example: ~~~ ruby tp = TracePoint.new(:script_compiled) do |e| p e.compiled_eval_script end tp.enable eval <<-eocode def omglolwut p :hello end eocode ~~~ When the tracepoint executes, we already know it's for a "compiled_script". So "compiled_eval_script" seems redundant. Just "eval_script", or "eval_source" seems good enough. ---------------------------------------- Feature #15287: New TracePoint events to support loading features https://bugs.ruby-lang.org/issues/15287#change-75556 * Author: ko1 (Koichi Sasada) * Status: Closed * Priority: Normal * Assignee: ko1 (Koichi Sasada) * Target version: 2.6 ---------------------------------------- # Abstract I propose the following new TracePoint events: * `loaded` (invoked after `require`/`load`) * `method_added` (invoked after method definition) # Background Sometimes we need to hook loading iseq. For example, checking loading files and so on. Also we want to know what kind of methods are defined. For both purpose, we can use some hook methods such as `Module#method_added` and so on. However, defining methods we can override this features. So that if we have two tools/libraries using this feature, they can be conflicted. # Proposal Introduce new TracePoint events: * `loaded` (invoked after `require`/`load`) * `method_added` (invoked after method definition) Also the following methods can be added: * Active only `loaded` event: * `TracePoint#loaded_feature` returns feature name. * `TracePoint#loaded_iseq` returns `RubyVM::InstructionSequence` object (MRI only, internal feature) # Optional proposal Add `class_added` alias name for `class` event. -- https://bugs.ruby-lang.org/