From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 9C87E20A1E for ; Mon, 10 Dec 2018 07:36:20 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 307F9121403; Mon, 10 Dec 2018 16:36:17 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id 99E4B121403 for ; Mon, 10 Dec 2018 16:36:14 +0900 (JST) Received: by filter0055p3mdw1.sendgrid.net with SMTP id filter0055p3mdw1-14213-5C0E176B-19 2018-12-10 07:36:11.574211543 +0000 UTC m=+458425.196205923 Received: from herokuapp.com (ec2-23-20-86-57.compute-1.amazonaws.com [23.20.86.57]) by ismtpd0026p1iad1.sendgrid.net (SG) with ESMTP id Pt-wo8kvSYGAri36fF0M9A for ; Mon, 10 Dec 2018 07:36:11.512 +0000 (UTC) Date: Mon, 10 Dec 2018 07:36:12 +0000 (UTC) From: ko1@atdot.net To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 65795 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 15287 X-Redmine-Issue-Author: ko1 X-Redmine-Issue-Assignee: ko1 X-Redmine-Sender: ko1 X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS59oszMuGNJOcj9A08Y24ok1PEkxtO1RSYstg bXv/z/65nNgFk11KaTISxm3bgI50z6u72V07PnUmsP6X1zNjXwgkxDVEKGavvwoSUyO0+hxu5TJ5/q ruPBjMQrDZwT49nxkeRONEIoFYgPqdUuXJfe X-ML-Name: ruby-core X-Mail-Count: 90401 Subject: [ruby-core:90401] [Ruby trunk Feature#15287] New TracePoint events to support loading features X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #15287 has been updated by ko1 (Koichi Sasada). English naming question! As I mentioned in commit log, I introduced the following two methods: * `TracePoint#compiled_instruction_sequence` method to get compiled `RubyVM::InstructionSequence` instance. * `TracePoint#compiled_eval_script` method to get compiled script (String) by `*eval` methods (return nil if compiling by file). Matz agreed with `TracePoint#compiled_instruction_sequence` but has question about `TracePoint#compiled_eval_script`. Both use prefix `compiled_` but we use two meanings: iseq is the result of compilation and `eval_script` is source string. The result and the source. Is it natural or do we have better name? ---------------------------------------- Feature #15287: New TracePoint events to support loading features https://bugs.ruby-lang.org/issues/15287#change-75544 * Author: ko1 (Koichi Sasada) * Status: Closed * Priority: Normal * Assignee: ko1 (Koichi Sasada) * Target version: 2.6 ---------------------------------------- # Abstract I propose the following new TracePoint events: * `loaded` (invoked after `require`/`load`) * `method_added` (invoked after method definition) # Background Sometimes we need to hook loading iseq. For example, checking loading files and so on. Also we want to know what kind of methods are defined. For both purpose, we can use some hook methods such as `Module#method_added` and so on. However, defining methods we can override this features. So that if we have two tools/libraries using this feature, they can be conflicted. # Proposal Introduce new TracePoint events: * `loaded` (invoked after `require`/`load`) * `method_added` (invoked after method definition) Also the following methods can be added: * Active only `loaded` event: * `TracePoint#loaded_feature` returns feature name. * `TracePoint#loaded_iseq` returns `RubyVM::InstructionSequence` object (MRI only, internal feature) # Optional proposal Add `class_added` alias name for `class` event. -- https://bugs.ruby-lang.org/