From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-2.6 required=3.0 tests=AWL,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_PASS shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 5D6BC20A1E for ; Fri, 7 Dec 2018 13:29:29 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id EC000121257; Fri, 7 Dec 2018 22:29:27 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id B4AF0120FD1 for ; Fri, 7 Dec 2018 22:29:24 +0900 (JST) Received: by filter0099p3iad2.sendgrid.net with SMTP id filter0099p3iad2-24016-5C0A75B1-21 2018-12-07 13:29:21.590210149 +0000 UTC m=+4954.490582156 Received: from herokuapp.com (ec2-54-211-34-192.compute-1.amazonaws.com [54.211.34.192]) by ismtpd0002p1iad1.sendgrid.net (SG) with ESMTP id XZ98rQy2TteNCouUUR7f7Q for ; Fri, 07 Dec 2018 13:29:21.484 +0000 (UTC) Date: Fri, 07 Dec 2018 13:29:22 +0000 (UTC) From: takashikkbn@gmail.com To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 65761 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 15391 X-Redmine-Issue-Author: vo.x X-Redmine-Issue-Assignee: nobu X-Redmine-Sender: k0kubun X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS7BxESpKM8ovgsG5e5U2HYHhafWzpneBLpZrt NMmI0PH2ckl0yIyzFiHgC1ryqoYyBMOZcoN76+T4PWWZ5voTyI0OpTZAwrPLGMJprepp9YBMx/jtD6 b2teBOrMtUIJkaD627zymXtwQmfhgAoApgESyjjy1eveQrRqahMkAsmlmw== X-ML-Name: ruby-core X-Mail-Count: 90370 Subject: [ruby-core:90370] [Ruby trunk Bug#15391][Feedback] JIT does not respect configuration options X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #15391 has been updated by k0kubun (Takashi Kokubun). Status changed from Open to Feedback Assignee changed from k0kubun (Takashi Kokubun) to nobu (Nobuyoshi Nakada) > there are 80+ JIT test cases failed Then, we can't merge, right? Also most of the changed places are mostly written by @nobu. Reassigning this to him because TBH I have no idea about how multi-arch build is working. ---------------------------------------- Bug #15391: JIT does not respect configuration options https://bugs.ruby-lang.org/issues/15391#change-75480 * Author: vo.x (Vit Ondruch) * Status: Feedback * Priority: Normal * Assignee: nobu (Nobuyoshi Nakada) * Target version: * ruby -v: ruby 2.6.0dev (2018-12-06 trunk 66252) [x86_64-linux] * Backport: 2.4: UNKNOWN, 2.5: UNKNOWN ---------------------------------------- JIT does not respect configuration options, mainly the header location options --with-rubyhdrdir, --with-rubyarchhdrdir, but it also ignores --with-ruby-version if I am not mistaken. So far I came up with the patch attached. But while it seems it places the headers on reasonable places, there are 80+ JIT test cases failed, because it obviously tries to locate the file on a place (e.g. absolute path) specified by configuration, but such place is not available during a build. ---Files-------------------------------- ruby-2.6.0-Make-JIT-honor-configured-Ruby-header-locations.patch (2.82 KB) -- https://bugs.ruby-lang.org/