ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: muraken@gmail.com
To: ruby-core@ruby-lang.org
Subject: [ruby-core:90350] [Ruby trunk Bug#15366][Closed] bigdecimal.c:3699:1: warning: ‘Zero’ defined but not used
Date: Fri, 07 Dec 2018 02:23:27 +0000 (UTC)	[thread overview]
Message-ID: <redmine.journal-75461.20181207022325.21308aad0c8f7405@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-15366.20181202094807@ruby-lang.org

Issue #15366 has been updated by mrkn (Kenta Murata).

Status changed from Open to Closed

Fixed in r 66222

----------------------------------------
Bug #15366: bigdecimal.c:3699:1: warning: ‘Zero’ defined but not used
https://bugs.ruby-lang.org/issues/15366#change-75461

* Author: duerst (Martin Dürst)
* Status: Closed
* Priority: Normal
* Assignee: mrkn (Kenta Murata)
* Target version: 
* ruby -v: ruby 2.6.0dev (2018-12-02 trunk 66129) [x86_64-cygwin]
* Backport: 2.4: UNKNOWN, 2.5: UNKNOWN
----------------------------------------
When compiling ruby trunk, I get a warning on bigdecimal.c:

```
compiling bigdecimal.c
bigdecimal.c:3699:1: warning: ‘Zero’ defined but not used [-Wunused-function]
 Zero(void)
 ^~~~
```

I had a quick look at the code. I indeed did find zero uses of the `Zero` function. I found one use of a similar `One` function. (Maybe that parallel is the point? :-)

I think the warning can easily be used by removing the Zero function and the constant it uses, or by using the Zero function once. But I didn't want to make a change in a part of the code that I don't really know.



-- 
https://bugs.ruby-lang.org/

      parent reply	other threads:[~2018-12-07  2:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <redmine.issue-15366.20181202094807@ruby-lang.org>
2018-12-02  9:48 ` [ruby-core:90221] [Ruby trunk Bug#15366] bigdecimal.c:3699:1: warning: ‘Zero’ defined but not used duerst
2018-12-07  2:23 ` muraken [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-75461.20181207022325.21308aad0c8f7405@ruby-lang.org \
    --to=ruby-core@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).