[ruby-core:90290] [Ruby trunk Feature#15350] [PATCH] thread_sync.c (queue_sleep): remove deadlock checking

[lars@greiz-reinsdorf.de]

Issue #15350 has been updated by larskanis (Lars Kanis).


I agree with Jeremy, that dropping the deadlock detection from `Queue#pop` would be pity. It's a lot easier if you get a clear error message, than debugging a starvation in your process.

A common mistake in [Eventbox](https://github.com/larskanis/eventbox) is to forget to yield the result of a `yield_call`. This blocks the call forever:

```ruby
class MyBox < Eventbox
  yield_call def init(result)
  end
end
MyBox.new
```

Fortunately is is immediately raised through a `fatal (No live threads left. Deadlock?)` error, since Eventbox uses a Queue internally in this case. And the stacktrace points to the blocked `yield_call`, so that the developer gets a good indication about what's missing.


----------------------------------------
Feature #15350: [PATCH] thread_sync.c (queue_sleep): remove deadlock checking
https://bugs.ruby-lang.org/issues/15350#change-75397

* Author: normalperson (Eric Wong)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
----------------------------------------
thread_sync.c (queue_sleep): remove deadlock checking

Queue may be used inside signal handlers nowadays, so deadlock
checking is unnecessary and prevents single-threaded use.

We don't have deadlock checking for reading pipes/socket or
File#flock, either.


This IS a behavior change; but I don't think there is a risk
of incompatibility (aside from future code not working on old Rubies)


---Files--------------------------------
0001-thread_sync.c-queue_sleep-remove-deadlock-checking.patch (2.44 KB)


-- 
https://bugs.ruby-lang.org/