From: Greg.mpls@gmail.com
To: ruby-core@ruby-lang.org
Subject: [ruby-core:90138] [Ruby trunk Bug#15348] r66003 Support targetting TracePoint - MinGW
Date: Wed, 28 Nov 2018 21:36:27 +0000 (UTC) [thread overview]
Message-ID: <redmine.journal-75254.20181128213625.beb64418c3dd91ad@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-15348.20181127194226@ruby-lang.org
Issue #15348 has been updated by MSP-Greg (Greg L).
@ko1 Koichi,
I did another ruby-loco build, and it also passed. The 'test repo' I did is here:
https://ci.appveyor.com/project/MSP-Greg/ruby-loco-test/history
Currently it runs three versions of the failing specs. In the first build, done before your fix, two of the three versions silent SEGV'd, and the third failed. The four builds (#2 thru #5) were done after the fix, all three versions passed in each. IOW, your fix certainly seems solid.
@k0kubun
When Appveyor is slow, it's very common for one or more TestJIT tests to fail running parallel but pass on retry. I've found the total build time (not test), along with the bootstraptest time are good indicators of how well test-all will go (or how busy Appveyor is).
Both of the 'post-fix' ruby-loco builds completed TestJIT when running parallel.
The second build was slow for both 'indicators', but TestJIT still had no parallel failures.
Thought I'd mention it, as I know you've wrestled with intermittent test issues on mingw/mswin...
Thanks to both of you for your work, Greg
----------------------------------------
Bug #15348: r66003 Support targetting TracePoint - MinGW
https://bugs.ruby-lang.org/issues/15348#change-75254
* Author: MSP-Greg (Greg L)
* Status: Open
* Priority: Normal
* Assignee:
* Target version:
* ruby -v:
* Backport: 2.4: UNKNOWN, 2.5: UNKNOWN
----------------------------------------
This has caused failures in spec/ruby/core/main/using_spec.rb, specifically the first spec.
On Appveyor, trying several versions of both specs, the first one (`eval('using', TOPLEVEL_BINDING)`) fails, the second one (`eval('using "foo"', TOPLEVEL_BINDING)`) passes.
Locally (Windows 10), all versions of both specs have always passed using the same build (saved as an artifact) from Appveyor...
--
https://bugs.ruby-lang.org/
prev parent reply other threads:[~2018-11-28 21:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <redmine.issue-15348.20181127194226@ruby-lang.org>
2018-11-27 19:42 ` [ruby-core:90094] [Ruby trunk Bug#15348] r66003 Support targetting TracePoint - MinGW Greg.mpls
2018-11-28 17:13 ` [ruby-core:90127] " Koichi Sasada
2018-11-28 18:41 ` [ruby-core:90132] " Greg.mpls
2018-11-28 21:36 ` Greg.mpls [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-75254.20181128213625.beb64418c3dd91ad@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).