ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: nagachika00@gmail.com
To: ruby-core@ruby-lang.org
Subject: [ruby-core:90121] [Ruby trunk Bug#15337] String#each_grapheme_cluster wrongly splits "\r\n"
Date: Wed, 28 Nov 2018 13:36:13 +0000 (UTC)	[thread overview]
Message-ID: <redmine.journal-75243.20181128133611.b0029099d19d92c9@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-15337.20181124085201@ruby-lang.org

Issue #15337 has been updated by nagachika (Tomoyuki Chikanaga).

Backport changed from 2.3: DONTNEED, 2.4: REQUIRED, 2.5: REQUIRED to 2.3: DONTNEED, 2.4: REQUIRED, 2.5: DONE

ruby_2_5 r66073 merged revision(s) 65954,65955,65958.

----------------------------------------
Bug #15337: String#each_grapheme_cluster wrongly splits "\r\n"
https://bugs.ruby-lang.org/issues/15337#change-75243

* Author: duerst (Martin Dürst)
* Status: Closed
* Priority: Normal
* Assignee: naruse (Yui NARUSE)
* Target version: 2.6
* ruby -v: ruby 2.6.0dev (2018-11-24 trunk 65950) [x86_64-linux]
* Backport: 2.3: DONTNEED, 2.4: REQUIRED, 2.5: DONE
----------------------------------------
The method `each_grapheme_cluster` on the `String` class wrongly splits CRLF into two clusters, as follows:

```
[duerst@stazersee ruby2]$ ./ruby -e 'puts "\r\n".each_grapheme_cluster.to_a.inspect'
["\r", "\n"]
[duerst@stazersee ruby2]$ ./ruby -v
ruby 2.6.0dev (2018-11-24 trunk 65950) [x86_64-linux]
```

The expected result in the above case is:
```
["\r\n"]
```

Except for the test cases that contain (unpaired) surrogates, which don't apply for us, this is the only test case that fails when testing with the data at http://www.unicode.org/Public/10.0.0/ucd/auxiliary/GraphemeBreakTest.txt. I have a test script using all that data that I plan to commit as soon as this bug is dealt with.

I would like to make sure that this is correct for Unicode 10.0.0 before moving to Unicode 11.0.0. In both specifications, the CRLF case is listed explicitly first in the specification.

I will try to find out how to fix this by myself, but would definitely appreciate help.





-- 
https://bugs.ruby-lang.org/

      parent reply	other threads:[~2018-11-28 13:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <redmine.issue-15337.20181124085201@ruby-lang.org>
2018-11-24  8:52 ` [ruby-core:90031] [Ruby trunk Bug#15337] String#each_grapheme_cluster wrongly splits "\r\n" duerst
2018-11-24 12:12 ` [ruby-core:90035] " duerst
2018-11-28 13:36 ` nagachika00 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-75243.20181128133611.b0029099d19d92c9@ruby-lang.org \
    --to=ruby-core@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).