From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-2.9 required=3.0 tests=AWL,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_PASS shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id E37FC1F87F for ; Fri, 23 Nov 2018 00:41:29 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 02DDE120E78; Fri, 23 Nov 2018 09:41:27 +0900 (JST) Received: from o1678916x28.outbound-mail.sendgrid.net (o1678916x28.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id A6807120E6D for ; Fri, 23 Nov 2018 09:41:24 +0900 (JST) Received: by filter0030p3iad2.sendgrid.net with SMTP id filter0030p3iad2-16316-5BF74CB1-6 2018-11-23 00:41:21.446708322 +0000 UTC m=+621249.501921773 Received: from herokuapp.com (ec2-54-196-130-1.compute-1.amazonaws.com [54.196.130.1]) by ismtpd0020p1iad2.sendgrid.net (SG) with ESMTP id W_vYLAakQvGWqlpgTh7zaQ Fri, 23 Nov 2018 00:41:21.470 +0000 (UTC) Date: Fri, 23 Nov 2018 00:41:22 +0000 (UTC) From: Greg.mpls@gmail.com To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 65392 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 14968 X-Redmine-Issue-Author: normalperson X-Redmine-Sender: MSP-Greg X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS5v0+lewA4AOM4UL+kJ6URKQAWIeH6n8EGuBx rrcvi5g4o+KBvyXAXA3Ks3/fIXZ/oP1TXRcq/XnuT1CAMVLmhuPLfrO+YyI5Rj8n4uTRQlKhUe9zok 0m39t7JHx7pfW9X/IVB9dk8uVU/GS/XgNDh3QOvrvalxUZjKHILR3g1MwQ== X-ML-Name: ruby-core X-Mail-Count: 89993 Subject: [ruby-core:89993] [Ruby trunk Bug#14968] [PATCH] io.c: make all pipes nonblocking by default X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #14968 has been updated by MSP-Greg (Greg L). File 14968_28_failures_errors.log added @normalperson Eric, Well, Appveyor testing can be intermittent. After r65931, the following issues in ruby Appveyor CI: ``` mswqin vc140 1) Failure: TestIO#test_readpartial_lock [C:/projects/ruby/test/ruby/test_io.rb:1366]: RuntimeError expected but nothing was raised. mingw Retrying... # terminated with exception (report_on_exception is true): C:/projects/ruby/test/ruby/test_io.rb:1364:in `readpartial': stream closed in another thread (IOError) from C:/projects/ruby/test/ruby/test_io.rb:1364:in `block (2 levels) in test_readpartial_lock' 1) Failure: TestIO#test_readpartial_lock [C:/projects/ruby/test/ruby/test_io.rb:1366]: RuntimeError expected but nothing was raised. ``` I've attached the test info from the ruby-loco build based on msg #28. Thanks, Greg ---------------------------------------- Bug #14968: [PATCH] io.c: make all pipes nonblocking by default https://bugs.ruby-lang.org/issues/14968#change-75098 * Author: normalperson (Eric Wong) * Status: Closed * Priority: Normal * Assignee: * Target version: * ruby -v: * Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN ---------------------------------------- Crap, I always planned to have something like this for [Feature #13618] (auto-Fiber); but introducing a race condition for Timer-thread elimination in [Misc #14937] forced me to introduce this early. Anyways, I might have to revert and reintroduce timer-thread if this change is unnacceptable :< (I HATE timer thread) ``` io.c: make all pipes nonblocking by default All normal Ruby IO methods (IO#read, IO#gets, IO#write, ...) are all capable of appearing to be "blocking" when presented with a file description with the O_NONBLOCK flag set; so there is little risk of incompatibility within Ruby-using programs. The biggest compatibility risk is when spawning external programs. As a result, stdin, stdout, and stderr are now always made blocking before exec-family calls. Timer-thread elimination in https://bugs.ruby-lang.org/issues/14937 introduced a race condition in signal handling. It is possible to receive a signal inside BLOCKING_REGION right before read/write syscalls. If this patch cannot be accepted, I will have to revert to reintroduce timer-thread and increase resource use (which led to other failures in the past). The race condition introduced for [Misc #14937] led to rare CI failures on a few tests: - test/ruby/test_thread.rb (test_thread_timer_and_interrupt): http://www.rubyist.net/~akr/chkbuild/debian/ruby-trunk/log/20180805T080500Z.fail.html.gz - test/ruby/test_io.rb (test_race_gets_and_close): http://ci.rvm.jp/results/trunk@P895/1190369 This change is ALSO necessary to take advantage of (proposed lightweight concurrency (aka "auto-Fiber") or any similar proposal: https://bugs.ruby-lang.org/issues/13618 TODO: all sockets and FIFOs non-blocking by default, too ``` ---Files-------------------------------- 0001-io.c-make-all-pipes-nonblocking-by-default.patch (12.1 KB) 14968_28_failures_errors.log (23.5 KB) -- https://bugs.ruby-lang.org/