From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-2.9 required=3.0 tests=AWL,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_PASS shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id BED671F87F for ; Thu, 22 Nov 2018 09:44:19 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 6D3EA121258; Thu, 22 Nov 2018 18:44:17 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id EB1D6121254 for ; Thu, 22 Nov 2018 18:44:15 +0900 (JST) Received: by filter0043p3iad2.sendgrid.net with SMTP id filter0043p3iad2-31579-5BF67A6C-D 2018-11-22 09:44:12.624568032 +0000 UTC m=+567615.410947138 Received: from herokuapp.com (ec2-54-81-117-10.compute-1.amazonaws.com [54.81.117.10]) by ismtpd0059p1mdw1.sendgrid.net (SG) with ESMTP id SFHLegijSOG-AwTxIYrEBA Thu, 22 Nov 2018 09:44:12.405 +0000 (UTC) Date: Thu, 22 Nov 2018 09:44:13 +0000 (UTC) From: takashikkbn@gmail.com To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 65364 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 14968 X-Redmine-Issue-Author: normalperson X-Redmine-Sender: k0kubun X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS5ioXsAePs+XX0pRKa03JrqtRxcTfn2hgiZLj oD4nBUnBozTZZRYRbpcfo384/6ZdxM+js6QjXtpX7Tkmi+k0Nh2QPDpSBQp9pfHc5M+EHyDTav9Rt+ t7HzSdOcTPmO8tBcpBzYgHSlWXMUSlshNi8lX3vy9hKwFagTaN3ONDfITg== X-ML-Name: ruby-core X-Mail-Count: 89965 Subject: [ruby-core:89965] [Ruby trunk Bug#14968] [PATCH] io.c: make all pipes nonblocking by default X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #14968 has been updated by k0kubun (Takashi Kokubun). r65922 made Travis x86_64-darwin build fail https://travis-ci.org/ruby/ruby/jobs/458319172. Could you take a look at it? ~~~ 1) Failure: TestSocket_BasicSocket#test_read_write_nonblock [/Users/travis/build/ruby/ruby/test/socket/test_basicsocket.rb:163]: Expected # to be nonblock?. Finished tests in 292.162445s, 68.6262 tests/s, 7798.3158 assertions/s. 20050 tests, 2278375 assertions, 1 failures, 0 errors, 61 skips ~~~ ---------------------------------------- Bug #14968: [PATCH] io.c: make all pipes nonblocking by default https://bugs.ruby-lang.org/issues/14968#change-75070 * Author: normalperson (Eric Wong) * Status: Closed * Priority: Normal * Assignee: * Target version: * ruby -v: * Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN ---------------------------------------- Crap, I always planned to have something like this for [Feature #13618] (auto-Fiber); but introducing a race condition for Timer-thread elimination in [Misc #14937] forced me to introduce this early. Anyways, I might have to revert and reintroduce timer-thread if this change is unnacceptable :< (I HATE timer thread) ``` io.c: make all pipes nonblocking by default All normal Ruby IO methods (IO#read, IO#gets, IO#write, ...) are all capable of appearing to be "blocking" when presented with a file description with the O_NONBLOCK flag set; so there is little risk of incompatibility within Ruby-using programs. The biggest compatibility risk is when spawning external programs. As a result, stdin, stdout, and stderr are now always made blocking before exec-family calls. Timer-thread elimination in https://bugs.ruby-lang.org/issues/14937 introduced a race condition in signal handling. It is possible to receive a signal inside BLOCKING_REGION right before read/write syscalls. If this patch cannot be accepted, I will have to revert to reintroduce timer-thread and increase resource use (which led to other failures in the past). The race condition introduced for [Misc #14937] led to rare CI failures on a few tests: - test/ruby/test_thread.rb (test_thread_timer_and_interrupt): http://www.rubyist.net/~akr/chkbuild/debian/ruby-trunk/log/20180805T080500Z.fail.html.gz - test/ruby/test_io.rb (test_race_gets_and_close): http://ci.rvm.jp/results/trunk@P895/1190369 This change is ALSO necessary to take advantage of (proposed lightweight concurrency (aka "auto-Fiber") or any similar proposal: https://bugs.ruby-lang.org/issues/13618 TODO: all sockets and FIFOs non-blocking by default, too ``` ---Files-------------------------------- 0001-io.c-make-all-pipes-nonblocking-by-default.patch (12.1 KB) -- https://bugs.ruby-lang.org/