From: rafaelmfranca@gmail.com
To: ruby-core@ruby-lang.org
Subject: [ruby-core:89754] [Ruby trunk Bug#15270] [PATCH] Fix TracePoint for code loaded using ISeq.load_from_binary
Date: Wed, 07 Nov 2018 19:25:09 +0000 (UTC) [thread overview]
Message-ID: <redmine.journal-74798.20181107192508.9cf1992a23ff81d1@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-15270.20181030144234@ruby-lang.org
Issue #15270 has been updated by rafaelfranca (Rafael França).
@ko1 can you mark this issue to be backported to 2.5.x please?
----------------------------------------
Bug #15270: [PATCH] Fix TracePoint for code loaded using ISeq.load_from_binary
https://bugs.ruby-lang.org/issues/15270#change-74798
* Author: alanwu (Alan Wu)
* Status: Closed
* Priority: Normal
* Assignee: ko1 (Koichi Sasada)
* Target version:
* ruby -v:
* Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN
----------------------------------------
Hello. This is a patch for Bug #14702, which I don't think is fully addressed.
The tests in the patch should fail on both trunk and ruby_2_5.
~~~
Fix TracePoint for nested iseq loaded from binary [Bug #14702]
When loading iseq from binary while a TracePoint is on, we need to
recompile instructions to their "trace_" variant. Before this commit
we only recompiled instructions in the top level iseq, which meant
that TracePoint was malfunctioning for code inside module/class/method
definitions.
* compile.c: Move rb_iseq_init_trace to rb_ibf_load_iseq_complete.
It is called on all iseqs during loading.
* test_iseq.rb: Test that tracepoints fire within children iseq when
using load_from_binary.
~~~
---Files--------------------------------
0001-Fix-TracePoint-for-nested-iseq-loaded-from-binary.patch (4.21 KB)
--
https://bugs.ruby-lang.org/
next prev parent reply other threads:[~2018-11-07 19:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <redmine.issue-15270.20181030144234@ruby-lang.org>
2018-10-30 14:42 ` [ruby-core:89641] [Ruby trunk Bug#15270] [PATCH] Fix TracePoint for code loaded using ISeq.load_from_binary alanwucanada
2018-10-30 14:50 ` [ruby-core:89642] " alanwucanada
2018-11-06 6:38 ` [ruby-core:89720] [Ruby trunk Bug#15270][Closed] " ko1
2018-11-07 19:25 ` rafaelmfranca [this message]
2018-12-05 14:35 ` [ruby-core:90314] [Ruby trunk Bug#15270] " nagachika00
2019-04-24 6:00 ` [ruby-core:92394] " nagachika00
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-74798.20181107192508.9cf1992a23ff81d1@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).