From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-3.1 required=3.0 tests=AWL,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id D279C1F453 for ; Tue, 30 Oct 2018 14:50:40 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 1267C120D7E; Tue, 30 Oct 2018 23:50:38 +0900 (JST) Received: from o1678916x28.outbound-mail.sendgrid.net (o1678916x28.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id 757C3120D77 for ; Tue, 30 Oct 2018 23:50:35 +0900 (JST) Received: by filter0024p3iad2.sendgrid.net with SMTP id filter0024p3iad2-2148-5BD86FB7-17 2018-10-30 14:50:31.530837814 +0000 UTC m=+16447.943659348 Received: from herokuapp.com (ec2-54-221-178-180.compute-1.amazonaws.com [54.221.178.180]) by ismtpd0002p1iad1.sendgrid.net (SG) with ESMTP id 8TkZdCRSTyWQIxxGy9WymA for ; Tue, 30 Oct 2018 14:50:31.478 +0000 (UTC) Date: Tue, 30 Oct 2018 14:50:32 +0000 (UTC) From: alanwucanada@gmail.com To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 65027 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 15270 X-Redmine-Issue-Author: alanwu X-Redmine-Sender: alanwu X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS5jSNN5dXAA/NbP8+coKD8PoN9npatyHy73bQ cYHosokmw+i7TCVzyCA5Ek01xrirM9HVbocH+BV3aBGEKRM3lxrh20wTIBmJzxsIejsMhRvqynuYuB NLbXcY/x5JhOpZKBneqqe3QONzCgv1pU9lAToM48QLOj4O6nbjinHwO/8A== X-ML-Name: ruby-core X-Mail-Count: 89642 Subject: [ruby-core:89642] [Ruby trunk Bug#15270] [PATCH] Fix TracePoint for code loaded using ISeq.load_from_binary X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #15270 has been updated by alanwu (Alan Wu). Description updated Typos ---------------------------------------- Bug #15270: [PATCH] Fix TracePoint for code loaded using ISeq.load_from_binary https://bugs.ruby-lang.org/issues/15270#change-74681 * Author: alanwu (Alan Wu) * Status: Open * Priority: Normal * Assignee: * Target version: * ruby -v: * Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN ---------------------------------------- Hello. This is a patch for Bug #14702, which I don't think is fully addressed. The tests in the patch should fail on both trunk and ruby_2_5. ~~~ Fix TracePoint for nested iseq loaded from binary [Bug #14702] When loading iseq from binary while a TracePoint is on, we need to recompile instructions to their "trace_" variant. Before this commit we only recompiled instructions in the top level iseq, which meant that TracePoint was malfunctioning for code inside module/class/method definitions. * compile.c: Move rb_iseq_init_trace to rb_ibf_load_iseq_complete. It is called on all iseqs during loading. * test_iseq.rb: Test that tracepoints fire within children iseq when using load_from_binary. ~~~ ---Files-------------------------------- 0001-Fix-TracePoint-for-nested-iseq-loaded-from-binary.patch (4.21 KB) -- https://bugs.ruby-lang.org/