From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 22E0C1F597 for ; Tue, 17 Jul 2018 04:39:34 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 796F0120A29; Tue, 17 Jul 2018 13:39:32 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id 1B08B120A29 for ; Tue, 17 Jul 2018 13:39:29 +0900 (JST) Received: by filter0123p3mdw1.sendgrid.net with SMTP id filter0123p3mdw1-20074-5B4D72FE-18 2018-07-17 04:39:26.881621016 +0000 UTC m=+28373.749713769 Received: from herokuapp.com (ec2-54-167-248-135.compute-1.amazonaws.com [54.167.248.135]) by ismtpd0005p1iad1.sendgrid.net (SG) with ESMTP id kjQVGvFqRD2RvaJEnd_EpQ for ; Tue, 17 Jul 2018 04:39:26.876 +0000 (UTC) Date: Tue, 17 Jul 2018 04:39:27 +0000 (UTC) From: mame@ruby-lang.org To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 63340 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 14915 X-Redmine-Issue-Author: jeremyevans0 X-Redmine-Sender: mame X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS6lyxWhek7Iis0xnF5C0gLnolyiLPTkokOwGV vhIY9IrYj8JMfayBGhYpUKh0+CuYYLBn3v1b5AfbKSnjQeSefdCmKBXpzJMHiJmdchrpgb0UyU7LBB Z0WRqcIYGMSGSzo6b4fMpLSFUr/A4RUJbB3wnQ7zqJAXv+UO75hoAckfZQ== X-ML-Name: ruby-core X-Mail-Count: 87966 Subject: [ruby-core:87966] [Ruby trunk Feature#14915] Deprecate String#crypt, move implementation to string/crypt X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #14915 has been updated by mame (Yusuke Endoh). I agree with deprecation and removal of String#crypt. If it were not included in the core, and if it were proposed today, the proposal would be definitely rejected as "it should be implemented as a gem". > This moves the String#crypt implementation to the string/crypt > extension, but leaves the String#crypt core method. The core > method prints a deprecation warning, then loads the string/crypt > extension. It looks complex a bit to me, and I don't see its advantage. How about: 2.6: core method deprecated, and a compatibility-layer gem released 3.0?: core method removed ? Unfortunately, the name "crypt" is [already taken](https://rubygems.org/gems/crypt), though... Incidentally, I found some usages of String#crypt in some gems. https://github.com/eventmachine/eventmachine/blob/537127fa22a058e3d7b248a214df210e7c77dc95/lib/em/protocols/postgres3.rb#L187 https://github.com/activeldap/activeldap/blob/a63e89c384cf7f5bb95451a3749e6dc4aa799969/lib/active_ldap/user_password.rb#L38 ---------------------------------------- Feature #14915: Deprecate String#crypt, move implementation to string/crypt https://bugs.ruby-lang.org/issues/14915#change-72972 * Author: jeremyevans0 (Jeremy Evans) * Status: Open * Priority: Normal * Assignee: * Target version: ---------------------------------------- This method is system and implementation dependent, and the portable usage mentioned in the documentation is not truly portable (doesn't work on OpenBSD) and insecure as it uses DES. For systems that lack a crypt(3) implementation, Ruby will happily substitute a version that only supports DES. It's 2018, using DES should be avoided if at all possible. The only internal usage of String#crypt in Ruby is in Webrick, where it uses DES for basic authentication with an htpasswd file. That could and should be changed to use a more secure hash by default (bcrypt since that's the most secure htpasswd format), or at least allow the user to customize Webrick's authentication. I expect there are few if any users actively using Webrick's htpasswd support. This moves the String#crypt implementation to the string/crypt extension, but leaves the String#crypt core method. The core method prints a deprecation warning, then loads the string/crypt extension. The string/crypt extension undefines the String#crypt core method, then defines the previous implementation. Because extensions use extconf.rb instead of configure for their configuration, this ports the related configure.ac code to extconf.rb. I'm not sure that is done correctly and works on all platforms, it will need testing. For systems that lack a crypt(3) implementation, this modifies the fallback code to only define crypt_r, since that is the only function that String#crypt will call in that case. While the patch just deprecates String#crypt, I think we should plan to remove support from ruby: 2.6: core method deprecated 2.7: core method removed, string/crypt extension ships with ruby 2.8: string/crypt extension moves to external gem, not shipped ---Files-------------------------------- 0001-Deprecate-String-crypt-move-implementation-to-string.patch (20.5 KB) -- https://bugs.ruby-lang.org/