[ruby-core:86545] [Ruby trunk Bug#14688] Net::HTTPResponse#value raises "Net::HTTPServerException" in 4xx response

[ruby-core:86545] [Ruby trunk Bug#14688] Net::HTTPResponse#value raises "Net::HTTPServerException" in 4xx response

[yusuke1994525]

Issue #14688 has been reported by unasuke (Yusuke Nakamura).

----------------------------------------
Bug #14688: Net::HTTPResponse#value raises "Net::HTTPServerException" in 4xx response
https://bugs.ruby-lang.org/issues/14688

* Author: unasuke (Yusuke Nakamura)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: 2.6.0dev
* Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN
----------------------------------------
Call `value` method to an instance of `Net::HTTPResponse` it raises `Net::HTTPServerException` in case of HTTP response status code is 4xx.

But HTTP response status code 4xx means "Client error response" not "Server response" so I think that's wrong naming.

https://developer.mozilla.org/en-US/docs/Web/HTTP/Status#Client_error_responses

Therefore, I think it's maybe specifications bug, but it cause breaking changes in many ruby programs to change exception name.

I propose to create `Net::HTTPClientException` as alias of the `Net::HTTPServerException` for compatibility.

---Files--------------------------------
lib_net_http_exceptions.patch (999 Bytes)


-- 
https://bugs.ruby-lang.org/

[ruby-core:86549] [Ruby trunk Bug#14688] Net::HTTPResponse#value raises "Net::HTTPServerException" in 4xx response

[takashikkbn]

Issue #14688 has been updated by k0kubun (Takashi Kokubun).


I like this. If nobody has an objection, I want to `deprecate_constant` the old one, and would like the same fix for Net::ProtoServerError as well.

----------------------------------------
Bug #14688: Net::HTTPResponse#value raises "Net::HTTPServerException" in 4xx response
https://bugs.ruby-lang.org/issues/14688#change-71489

* Author: unasuke (Yusuke Nakamura)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: 2.6.0dev
* Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN
----------------------------------------
Call `value` method to an instance of `Net::HTTPResponse` it raises `Net::HTTPServerException` in case of HTTP response status code is 4xx.

But HTTP response status code 4xx means "Client error response" not "Server response" so I think that's wrong naming.

https://developer.mozilla.org/en-US/docs/Web/HTTP/Status#Client_error_responses

Therefore, I think it's maybe specifications bug, but it cause breaking changes in many ruby programs to change exception name.

I propose to create `Net::HTTPClientException` as alias of the `Net::HTTPServerException` for compatibility.

---Files--------------------------------
lib_net_http_exceptions.patch (999 Bytes)


-- 
https://bugs.ruby-lang.org/

[ruby-core:86557] [Ruby trunk Bug#14688] Net::HTTPResponse#value raises "Net::HTTPServerException" in 4xx response

[shevegen]

Issue #14688 has been updated by shevegen (Robert A. Heiler).


The described transition path makes sense (to me).

----------------------------------------
Bug #14688: Net::HTTPResponse#value raises "Net::HTTPServerException" in 4xx response
https://bugs.ruby-lang.org/issues/14688#change-71498

* Author: unasuke (Yusuke Nakamura)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: 2.6.0dev
* Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN
----------------------------------------
Call `value` method to an instance of `Net::HTTPResponse` it raises `Net::HTTPServerException` in case of HTTP response status code is 4xx.

But HTTP response status code 4xx means "Client error response" not "Server response" so I think that's wrong naming.

https://developer.mozilla.org/en-US/docs/Web/HTTP/Status#Client_error_responses

Therefore, I think it's maybe specifications bug, but it cause breaking changes in many ruby programs to change exception name.

I propose to create `Net::HTTPClientException` as alias of the `Net::HTTPServerException` for compatibility.

---Files--------------------------------
lib_net_http_exceptions.patch (999 Bytes)


-- 
https://bugs.ruby-lang.org/

[ruby-core:86608] [Ruby trunk Bug#14688][Assigned] Net::HTTPResponse#value raises "Net::HTTPServerException" in 4xx response

[usa]

Issue #14688 has been updated by usa (Usaku NAKAMURA).

Status changed from Open to Assigned
Assignee set to naruse (Yui NARUSE)

At DevelopersMeeting20180419Japan, adding the alias is accepted.

----------------------------------------
Bug #14688: Net::HTTPResponse#value raises "Net::HTTPServerException" in 4xx response
https://bugs.ruby-lang.org/issues/14688#change-71565

* Author: unasuke (Yusuke Nakamura)
* Status: Assigned
* Priority: Normal
* Assignee: naruse (Yui NARUSE)
* Target version: 
* ruby -v: 2.6.0dev
* Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN
----------------------------------------
Call `value` method to an instance of `Net::HTTPResponse` it raises `Net::HTTPServerException` in case of HTTP response status code is 4xx.

But HTTP response status code 4xx means "Client error response" not "Server response" so I think that's wrong naming.

https://developer.mozilla.org/en-US/docs/Web/HTTP/Status#Client_error_responses

Therefore, I think it's maybe specifications bug, but it cause breaking changes in many ruby programs to change exception name.

I propose to create `Net::HTTPClientException` as alias of the `Net::HTTPServerException` for compatibility.

---Files--------------------------------
lib_net_http_exceptions.patch (999 Bytes)


-- 
https://bugs.ruby-lang.org/

[ruby-core:86970] [Ruby trunk Bug#14688] Net::HTTPResponse#value raises "Net::HTTPServerException" in 4xx response

[yusuke1994525]

Issue #14688 has been updated by unasuke (Yusuke Nakamura).

File lib_net_http_exceptions_with_deprecate.patch added

k0kubun (Takashi Kokubun) wrote:
> I like this. If nobody has an objection, I want to `deprecate_constant` the old one, and would like the same fix for Net::ProtoServerError as well.

I updated the patch. Like this?

----------------------------------------
Bug #14688: Net::HTTPResponse#value raises "Net::HTTPServerException" in 4xx response
https://bugs.ruby-lang.org/issues/14688#change-71936

* Author: unasuke (Yusuke Nakamura)
* Status: Assigned
* Priority: Normal
* Assignee: naruse (Yui NARUSE)
* Target version: 
* ruby -v: 2.6.0dev
* Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN
----------------------------------------
Call `value` method to an instance of `Net::HTTPResponse` it raises `Net::HTTPServerException` in case of HTTP response status code is 4xx.

But HTTP response status code 4xx means "Client error response" not "Server response" so I think that's wrong naming.

https://developer.mozilla.org/en-US/docs/Web/HTTP/Status#Client_error_responses

Therefore, I think it's maybe specifications bug, but it cause breaking changes in many ruby programs to change exception name.

I propose to create `Net::HTTPClientException` as alias of the `Net::HTTPServerException` for compatibility.

---Files--------------------------------
lib_net_http_exceptions.patch (999 Bytes)
lib_net_http_exceptions_with_deprecate.patch (1.08 KB)


-- 
https://bugs.ruby-lang.org/

[ruby-core:87488] [Ruby trunk Feature#14688] Net::HTTPResponse#value raises "Net::HTTPServerException" in 4xx response

[usa]

Issue #14688 has been updated by usa (Usaku NAKAMURA).


I suspect that deprecating `Net::ProtoServerError` is wrong.
The exception seems to be "something error reported from server", and is derived not only by `Net::HTTPServerException` but also `Net::SMTPServerBusy`. 

----------------------------------------
Feature #14688: Net::HTTPResponse#value raises "Net::HTTPServerException" in 4xx response
https://bugs.ruby-lang.org/issues/14688#change-72490

* Author: unasuke (Yusuke Nakamura)
* Status: Closed
* Priority: Normal
* Assignee: naruse (Yui NARUSE)
* Target version: 
----------------------------------------
Call `value` method to an instance of `Net::HTTPResponse` it raises `Net::HTTPServerException` in case of HTTP response status code is 4xx.

But HTTP response status code 4xx means "Client error response" not "Server response" so I think that's wrong naming.

https://developer.mozilla.org/en-US/docs/Web/HTTP/Status#Client_error_responses

Therefore, I think it's maybe specifications bug, but it cause breaking changes in many ruby programs to change exception name.

I propose to create `Net::HTTPClientException` as alias of the `Net::HTTPServerException` for compatibility.

---Files--------------------------------
lib_net_http_exceptions.patch (999 Bytes)
lib_net_http_exceptions_with_deprecate.patch (1.08 KB)


-- 
https://bugs.ruby-lang.org/