From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-2.1 required=3.0 tests=BAYES_00,DKIM_ADSP_ALL, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_MED,SPF_PASS,T_RP_MATCHES_RCVD shortcircuit=no autolearn=no autolearn_force=no version=3.4.0 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 68BAC1F404 for ; Sat, 31 Mar 2018 14:26:12 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id A536A120938; Sat, 31 Mar 2018 23:26:10 +0900 (JST) Authentication-Results: neon.ruby-lang.org; dkim=none reason="no signature"; dkim-adsp=fail (insecure policy); dkim-atps=neutral Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id 79313120924 for ; Sat, 31 Mar 2018 23:26:08 +0900 (JST) Received: by filter0002p3las1.sendgrid.net with SMTP id filter0002p3las1-13121-5ABF9A7D-18 2018-03-31 14:26:05.376093852 +0000 UTC Received: from herokuapp.com (ec2-54-92-157-231.compute-1.amazonaws.com [54.92.157.231]) by ismtpd0044p1mdw1.sendgrid.net (SG) with ESMTP id iphL2-EQTyWJ3VWE_M2rOQ Sat, 31 Mar 2018 14:26:05.191 +0000 (UTC) Date: Sat, 31 Mar 2018 14:26:05 +0000 (UTC) From: kou@cozmixng.org To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 61757 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 10364 X-Redmine-Issue-Author: jisraelson X-Redmine-Issue-Assignee: kou X-Redmine-Sender: kou X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS45ma3PsxCIsHSV24RV+RQuV+XIN7h/qFgQtW wg/k5IvD6qonfvdPp7KMoRrqv91C4eFXRk5ExwCKTKTdP+10LE4I+rWf9HbY2up8gKuApMJBJoeEZW LnZquIaBB793T/iReDDe9ahm7OfeNGDJZmNENN4W18Hv8Mla0LPNVB/9iw== X-ML-Name: ruby-core X-Mail-Count: 86415 Subject: [ruby-core:86415] [Ruby trunk Bug#10364][Rejected] Malformed CSV Header Causes NoMethodError X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #10364 has been updated by kou (Kouhei Sutou). Status changed from Assigned to Rejected It seems that this has been fixed in master. If someone knows a script that reproduces this case, you can attach the script and reopen this. ---------------------------------------- Bug #10364: Malformed CSV Header Causes NoMethodError https://bugs.ruby-lang.org/issues/10364#change-71350 * Author: jisraelson (Jon Israelson) * Status: Rejected * Priority: Normal * Assignee: kou (Kouhei Sutou) * Target version: * ruby -v: ruby 2.1.3p242 (2014-09-19 revision 47630) [x86_64-darwin13.0] * Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN ---------------------------------------- The method CSV#readline raises a "NoMethodError: undefined method 'encode' for nil:NilClass" exception when the CSV file's header row contains a trailing delimiter (a comma in my case). The following CSV data can be used to recreate this error: ~~~ col1,col2, 1,2 3,4 ~~~ The resulting stack trace: ~~~ csv.rb:993:in `block in ' csv.rb:2175:in `[]' csv.rb:2175:in `block (2 levels) in convert_fields' csv.rb:2173:in `each' csv.rb:2173:in `block in convert_fields' csv.rb:2172:in `map' csv.rb:2172:in `with_index' csv.rb:2172:in `convert_fields' csv.rb:2213:in `parse_headers' csv.rb:1887:in `block in shift' csv.rb:1779:in `loop' csv.rb:1779:in `shift' ~~~ Assuming that the header row is considered malformed (IMHO it is), it seems that it would be better to raise a CSV::MalformedCSVError exception, which can be more easily handled. -- https://bugs.ruby-lang.org/