ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
* [ruby-core:65597] [ruby-trunk - Bug #10364] [Open] Malformed CSV Header Causes NoMethodError
       [not found] <redmine.issue-10364.20141010155313@ruby-lang.org>
@ 2014-10-10 15:53 ` jisraelson
  2014-10-13  7:41 ` [ruby-core:65651] [ruby-trunk - Bug #10364] [Assigned] " shibata.hiroshi
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 5+ messages in thread
From: jisraelson @ 2014-10-10 15:53 UTC (permalink / raw
  To: ruby-core

Issue #10364 has been reported by Jon Israelson.

----------------------------------------
Bug #10364: Malformed CSV Header Causes NoMethodError
https://bugs.ruby-lang.org/issues/10364

* Author: Jon Israelson
* Status: Open
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 
* ruby -v: ruby 2.1.3p242 (2014-09-19 revision 47630) [x86_64-darwin13.0]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN
----------------------------------------
The method CSV#readline raises a "NoMethodError: undefined method 'encode' for nil:NilClass" exception when the CSV file's header row contains a trailing delimiter (a comma in my case).  The following CSV data can be used to recreate this error:

~~~
col1,col2,
1,2
3,4
~~~

The resulting stack trace:

~~~
csv.rb:993:in `block in <class:CSV>'
csv.rb:2175:in `[]'
csv.rb:2175:in `block (2 levels) in convert_fields'
csv.rb:2173:in `each'
csv.rb:2173:in `block in convert_fields'
csv.rb:2172:in `map'
csv.rb:2172:in `with_index'
csv.rb:2172:in `convert_fields'
csv.rb:2213:in `parse_headers'
csv.rb:1887:in `block in shift'
csv.rb:1779:in `loop'
csv.rb:1779:in `shift'
~~~

Assuming that the header row is considered malformed (IMHO it is), it seems that it would be better to raise a CSV::MalformedCSVError exception, which can be more easily handled.




-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [ruby-core:65651] [ruby-trunk - Bug #10364] [Assigned] Malformed CSV Header Causes NoMethodError
       [not found] <redmine.issue-10364.20141010155313@ruby-lang.org>
  2014-10-10 15:53 ` [ruby-core:65597] [ruby-trunk - Bug #10364] [Open] Malformed CSV Header Causes NoMethodError jisraelson
@ 2014-10-13  7:41 ` shibata.hiroshi
  2014-11-30  6:56 ` [ruby-core:66585] [ruby-trunk - Bug #10364] " jrodrigosm
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 5+ messages in thread
From: shibata.hiroshi @ 2014-10-13  7:41 UTC (permalink / raw
  To: ruby-core

Issue #10364 has been updated by Hiroshi SHIBATA.

Status changed from Open to Assigned
Assignee set to James Gray

----------------------------------------
Bug #10364: Malformed CSV Header Causes NoMethodError
https://bugs.ruby-lang.org/issues/10364#change-49383

* Author: Jon Israelson
* Status: Assigned
* Priority: Normal
* Assignee: James Gray
* Category: 
* Target version: 
* ruby -v: ruby 2.1.3p242 (2014-09-19 revision 47630) [x86_64-darwin13.0]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN
----------------------------------------
The method CSV#readline raises a "NoMethodError: undefined method 'encode' for nil:NilClass" exception when the CSV file's header row contains a trailing delimiter (a comma in my case).  The following CSV data can be used to recreate this error:

~~~
col1,col2,
1,2
3,4
~~~

The resulting stack trace:

~~~
csv.rb:993:in `block in <class:CSV>'
csv.rb:2175:in `[]'
csv.rb:2175:in `block (2 levels) in convert_fields'
csv.rb:2173:in `each'
csv.rb:2173:in `block in convert_fields'
csv.rb:2172:in `map'
csv.rb:2172:in `with_index'
csv.rb:2172:in `convert_fields'
csv.rb:2213:in `parse_headers'
csv.rb:1887:in `block in shift'
csv.rb:1779:in `loop'
csv.rb:1779:in `shift'
~~~

Assuming that the header row is considered malformed (IMHO it is), it seems that it would be better to raise a CSV::MalformedCSVError exception, which can be more easily handled.




-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [ruby-core:66585] [ruby-trunk - Bug #10364] Malformed CSV Header Causes NoMethodError
       [not found] <redmine.issue-10364.20141010155313@ruby-lang.org>
  2014-10-10 15:53 ` [ruby-core:65597] [ruby-trunk - Bug #10364] [Open] Malformed CSV Header Causes NoMethodError jisraelson
  2014-10-13  7:41 ` [ruby-core:65651] [ruby-trunk - Bug #10364] [Assigned] " shibata.hiroshi
@ 2014-11-30  6:56 ` jrodrigosm
  2018-03-08  7:34 ` [ruby-core:86028] [Ruby trunk Bug#10364] " mame
  2018-03-31 14:26 ` [ruby-core:86415] [Ruby trunk Bug#10364][Rejected] " kou
  4 siblings, 0 replies; 5+ messages in thread
From: jrodrigosm @ 2014-11-30  6:56 UTC (permalink / raw
  To: ruby-core

Issue #10364 has been updated by Rodrigo Serrano.


This issue is also present in ruby 2.1.5p273 (2014-11-13 revision 48405) [x86_64-linux]

----------------------------------------
Bug #10364: Malformed CSV Header Causes NoMethodError
https://bugs.ruby-lang.org/issues/10364#change-50200

* Author: Jon Israelson
* Status: Assigned
* Priority: Normal
* Assignee: James Gray
* Category: 
* Target version: 
* ruby -v: ruby 2.1.3p242 (2014-09-19 revision 47630) [x86_64-darwin13.0]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN
----------------------------------------
The method CSV#readline raises a "NoMethodError: undefined method 'encode' for nil:NilClass" exception when the CSV file's header row contains a trailing delimiter (a comma in my case).  The following CSV data can be used to recreate this error:

~~~
col1,col2,
1,2
3,4
~~~

The resulting stack trace:

~~~
csv.rb:993:in `block in <class:CSV>'
csv.rb:2175:in `[]'
csv.rb:2175:in `block (2 levels) in convert_fields'
csv.rb:2173:in `each'
csv.rb:2173:in `block in convert_fields'
csv.rb:2172:in `map'
csv.rb:2172:in `with_index'
csv.rb:2172:in `convert_fields'
csv.rb:2213:in `parse_headers'
csv.rb:1887:in `block in shift'
csv.rb:1779:in `loop'
csv.rb:1779:in `shift'
~~~

Assuming that the header row is considered malformed (IMHO it is), it seems that it would be better to raise a CSV::MalformedCSVError exception, which can be more easily handled.




-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [ruby-core:86028] [Ruby trunk Bug#10364] Malformed CSV Header Causes NoMethodError
       [not found] <redmine.issue-10364.20141010155313@ruby-lang.org>
                   ` (2 preceding siblings ...)
  2014-11-30  6:56 ` [ruby-core:66585] [ruby-trunk - Bug #10364] " jrodrigosm
@ 2018-03-08  7:34 ` mame
  2018-03-31 14:26 ` [ruby-core:86415] [Ruby trunk Bug#10364][Rejected] " kou
  4 siblings, 0 replies; 5+ messages in thread
From: mame @ 2018-03-08  7:34 UTC (permalink / raw
  To: ruby-core

Issue #10364 has been updated by mame (Yusuke Endoh).

Assignee changed from JEG2 (James Gray) to kou (Kouhei Sutou)

@kou, could you check this ticket?

----------------------------------------
Bug #10364: Malformed CSV Header Causes NoMethodError
https://bugs.ruby-lang.org/issues/10364#change-70888

* Author: jisraelson (Jon Israelson)
* Status: Assigned
* Priority: Normal
* Assignee: kou (Kouhei Sutou)
* Target version: 
* ruby -v: ruby 2.1.3p242 (2014-09-19 revision 47630) [x86_64-darwin13.0]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN
----------------------------------------
The method CSV#readline raises a "NoMethodError: undefined method 'encode' for nil:NilClass" exception when the CSV file's header row contains a trailing delimiter (a comma in my case).  The following CSV data can be used to recreate this error:

~~~
col1,col2,
1,2
3,4
~~~

The resulting stack trace:

~~~
csv.rb:993:in `block in <class:CSV>'
csv.rb:2175:in `[]'
csv.rb:2175:in `block (2 levels) in convert_fields'
csv.rb:2173:in `each'
csv.rb:2173:in `block in convert_fields'
csv.rb:2172:in `map'
csv.rb:2172:in `with_index'
csv.rb:2172:in `convert_fields'
csv.rb:2213:in `parse_headers'
csv.rb:1887:in `block in shift'
csv.rb:1779:in `loop'
csv.rb:1779:in `shift'
~~~

Assuming that the header row is considered malformed (IMHO it is), it seems that it would be better to raise a CSV::MalformedCSVError exception, which can be more easily handled.




-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [ruby-core:86415] [Ruby trunk Bug#10364][Rejected] Malformed CSV Header Causes NoMethodError
       [not found] <redmine.issue-10364.20141010155313@ruby-lang.org>
                   ` (3 preceding siblings ...)
  2018-03-08  7:34 ` [ruby-core:86028] [Ruby trunk Bug#10364] " mame
@ 2018-03-31 14:26 ` kou
  4 siblings, 0 replies; 5+ messages in thread
From: kou @ 2018-03-31 14:26 UTC (permalink / raw
  To: ruby-core

Issue #10364 has been updated by kou (Kouhei Sutou).

Status changed from Assigned to Rejected

It seems that this has been fixed in master.
If someone knows a script that reproduces this case, you can attach the script and reopen this.

----------------------------------------
Bug #10364: Malformed CSV Header Causes NoMethodError
https://bugs.ruby-lang.org/issues/10364#change-71350

* Author: jisraelson (Jon Israelson)
* Status: Rejected
* Priority: Normal
* Assignee: kou (Kouhei Sutou)
* Target version: 
* ruby -v: ruby 2.1.3p242 (2014-09-19 revision 47630) [x86_64-darwin13.0]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN
----------------------------------------
The method CSV#readline raises a "NoMethodError: undefined method 'encode' for nil:NilClass" exception when the CSV file's header row contains a trailing delimiter (a comma in my case).  The following CSV data can be used to recreate this error:

~~~
col1,col2,
1,2
3,4
~~~

The resulting stack trace:

~~~
csv.rb:993:in `block in <class:CSV>'
csv.rb:2175:in `[]'
csv.rb:2175:in `block (2 levels) in convert_fields'
csv.rb:2173:in `each'
csv.rb:2173:in `block in convert_fields'
csv.rb:2172:in `map'
csv.rb:2172:in `with_index'
csv.rb:2172:in `convert_fields'
csv.rb:2213:in `parse_headers'
csv.rb:1887:in `block in shift'
csv.rb:1779:in `loop'
csv.rb:1779:in `shift'
~~~

Assuming that the header row is considered malformed (IMHO it is), it seems that it would be better to raise a CSV::MalformedCSVError exception, which can be more easily handled.




-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-03-31 14:26 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <redmine.issue-10364.20141010155313@ruby-lang.org>
2014-10-10 15:53 ` [ruby-core:65597] [ruby-trunk - Bug #10364] [Open] Malformed CSV Header Causes NoMethodError jisraelson
2014-10-13  7:41 ` [ruby-core:65651] [ruby-trunk - Bug #10364] [Assigned] " shibata.hiroshi
2014-11-30  6:56 ` [ruby-core:66585] [ruby-trunk - Bug #10364] " jrodrigosm
2018-03-08  7:34 ` [ruby-core:86028] [Ruby trunk Bug#10364] " mame
2018-03-31 14:26 ` [ruby-core:86415] [Ruby trunk Bug#10364][Rejected] " kou

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).