From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-2.3 required=3.0 tests=AWL,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_MED,SPF_PASS,T_RP_MATCHES_RCVD shortcircuit=no autolearn=no autolearn_force=no version=3.4.0 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 873FC1F406 for ; Tue, 9 Jan 2018 17:14:10 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 02DBB120A2C; Wed, 10 Jan 2018 02:14:09 +0900 (JST) Received: from o1678916x28.outbound-mail.sendgrid.net (o1678916x28.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id 80600120A2A for ; Wed, 10 Jan 2018 02:13:57 +0900 (JST) Received: by filter0016p3las1.sendgrid.net with SMTP id filter0016p3las1-12216-5A54F851-12 2018-01-09 17:13:53.216644606 +0000 UTC Received: from herokuapp.com (ec2-54-224-151-203.compute-1.amazonaws.com [54.224.151.203]) by ismtpd0006p1iad2.sendgrid.net (SG) with ESMTP id W7kB7IMLTlOzdxFgjRfYpg Tue, 09 Jan 2018 17:13:53.366 +0000 (UTC) Date: Tue, 09 Jan 2018 17:13:53 +0000 (UTC) From: eregontp@gmail.com To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 60013 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 14344 X-Redmine-Issue-Author: kddeisz X-Redmine-Sender: Eregon X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS7Vjx8OAYoHGlfuYkjGV3Pign8RrL6AEaD+ch 5D5g0ZaFS229mrtnBUqzz717xNJHKzvdCh72xnGl4WZC/GdYvAF58wZqK9l7MSIqm1aEudJ4y86G0/ 0Y4dHSs4WQcr9jn3F/XyyhMKKu2BRWEE3BlnwvQr6JTRAwN36SxLyruC3A== X-ML-Name: ruby-core X-Mail-Count: 84780 Subject: [ruby-core:84780] [Ruby trunk Feature#14344] refine at class level X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #14344 has been updated by Eregon (Benoit Daloze). The whole purpose of the Module around it is so multiple refinements can be bundled up together in a Module and that Module is passed to #using. I don't think #refine should enable refinements after the block. It doesn't seem clear to me and is too confusing with the existing usage of #refine. Whether #refine is called on a Module or not would have very different semantics. Also I guess in general refinements are not defined right in the class using them, especially if they are not trivial one-liner methods. ---------------------------------------- Feature #14344: refine at class level https://bugs.ruby-lang.org/issues/14344#change-69496 * Author: kddeisz (Kevin Deisz) * Status: Open * Priority: Normal * Assignee: * Target version: ---------------------------------------- I rely on refinements a lot, but don't want to keep writing `Module.new` in code. I'm proposing `Object::refine`, which would create an anonymous module behind the scenes with equivalent functionality. So: ~~~ ruby class Test using Module.new { refine String do def refined? true end end } end ~~~ would become ~~~ ruby class Test refine String do def refined? true end end end ~~~ It's a small change, but reads a lot more clearly. Thoughts? -- https://bugs.ruby-lang.org/