ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
* [ruby-core:69745] [Ruby trunk - Bug #11310] [Open] CSV::Table#to_csv should use concat not +
       [not found] <redmine.issue-11310.20150626151615@ruby-lang.org>
@ 2015-06-26 15:16 ` zach.dennis
  2017-05-10 11:38 ` [ruby-core:81091] [Ruby trunk Bug#11310][Assigned] " hsbt
  2017-09-19  8:52 ` [ruby-core:82869] [Ruby trunk Bug#11310][Closed] " hsbt
  2 siblings, 0 replies; 3+ messages in thread
From: zach.dennis @ 2015-06-26 15:16 UTC (permalink / raw
  To: ruby-core

Issue #11310 has been reported by Zach Dennis.

----------------------------------------
Bug #11310: CSV::Table#to_csv should use concat not +
https://bugs.ruby-lang.org/issues/11310

* Author: Zach Dennis
* Status: Open
* Priority: Normal
* Assignee: 
* ruby -v: ruby 2.2.2p95 (2015-04-13 revision 50295) [x86_64-linux-gnu]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
The current implementation of CSV::Table#to_a method uses Array#+ to which is really bad on performance. It seems like it should use Array#concat.

Relevant Github PR: https://github.com/ruby/ruby/pull/946



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [ruby-core:81091] [Ruby trunk Bug#11310][Assigned] CSV::Table#to_csv should use concat not +
       [not found] <redmine.issue-11310.20150626151615@ruby-lang.org>
  2015-06-26 15:16 ` [ruby-core:69745] [Ruby trunk - Bug #11310] [Open] CSV::Table#to_csv should use concat not + zach.dennis
@ 2017-05-10 11:38 ` hsbt
  2017-09-19  8:52 ` [ruby-core:82869] [Ruby trunk Bug#11310][Closed] " hsbt
  2 siblings, 0 replies; 3+ messages in thread
From: hsbt @ 2017-05-10 11:38 UTC (permalink / raw
  To: ruby-core

Issue #11310 has been updated by hsbt (Hiroshi SHIBATA).

Status changed from Open to Assigned
Assignee set to hsbt (Hiroshi SHIBATA)

----------------------------------------
Bug #11310: CSV::Table#to_csv should use concat not +
https://bugs.ruby-lang.org/issues/11310#change-64740

* Author: zdennis (Zach Dennis)
* Status: Assigned
* Priority: Normal
* Assignee: hsbt (Hiroshi SHIBATA)
* Target version: 
* ruby -v: ruby 2.2.2p95 (2015-04-13 revision 50295) [x86_64-linux-gnu]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
The current implementation of CSV::Table#to_a method uses Array#+ to which is really bad on performance. It seems like it should use Array#concat.

Relevant Github PR: https://github.com/ruby/ruby/pull/946



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [ruby-core:82869] [Ruby trunk Bug#11310][Closed] CSV::Table#to_csv should use concat not +
       [not found] <redmine.issue-11310.20150626151615@ruby-lang.org>
  2015-06-26 15:16 ` [ruby-core:69745] [Ruby trunk - Bug #11310] [Open] CSV::Table#to_csv should use concat not + zach.dennis
  2017-05-10 11:38 ` [ruby-core:81091] [Ruby trunk Bug#11310][Assigned] " hsbt
@ 2017-09-19  8:52 ` hsbt
  2 siblings, 0 replies; 3+ messages in thread
From: hsbt @ 2017-09-19  8:52 UTC (permalink / raw
  To: ruby-core

Issue #11310 has been updated by hsbt (Hiroshi SHIBATA).

Status changed from Assigned to Closed
Backport changed from 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN to 2.2: DONTNEED, 2.3: DONTNEED, 2.4: DONTNEED

applied at r59657

----------------------------------------
Bug #11310: CSV::Table#to_csv should use concat not +
https://bugs.ruby-lang.org/issues/11310#change-66769

* Author: zdennis (Zach Dennis)
* Status: Closed
* Priority: Normal
* Assignee: hsbt (Hiroshi SHIBATA)
* Target version: 
* ruby -v: ruby 2.2.2p95 (2015-04-13 revision 50295) [x86_64-linux-gnu]
* Backport: 2.2: DONTNEED, 2.3: DONTNEED, 2.4: DONTNEED
----------------------------------------
The current implementation of CSV::Table#to_a method uses Array#+ to which is really bad on performance. It seems like it should use Array#concat.

Relevant Github PR: https://github.com/ruby/ruby/pull/946



-- 
https://bugs.ruby-lang.org/

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-09-19  8:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <redmine.issue-11310.20150626151615@ruby-lang.org>
2015-06-26 15:16 ` [ruby-core:69745] [Ruby trunk - Bug #11310] [Open] CSV::Table#to_csv should use concat not + zach.dennis
2017-05-10 11:38 ` [ruby-core:81091] [Ruby trunk Bug#11310][Assigned] " hsbt
2017-09-19  8:52 ` [ruby-core:82869] [Ruby trunk Bug#11310][Closed] " hsbt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).