From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-3.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_MED,SPF_PASS,T_DKIM_INVALID, T_RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 9D8AD1F7D2 for ; Mon, 5 Jun 2017 16:32:12 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 7234B120779; Tue, 6 Jun 2017 01:32:10 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id EAF3012076B for ; Tue, 6 Jun 2017 01:32:08 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=NhM9tMBSE+uLRrPB+4q6bxRiwAo=; b=XQJpQ3g6XFbwdWchi1 w4FAF5c9LXCIAXe5WXmSHmKs0SdqbCaWDWxIkX0sTJivFzd6fWPiEBkR9z/ExKBh 7/AXXvLlBPvXRLkMX3o2ucDSidFrwYi0vJoDuWc/G+lVDKuOc3o+H/iExd11H40V AgPsn095Ynin3GsgtwZfq4lI4= Received: by filter1174p1mdw1.sendgrid.net with SMTP id filter1174p1mdw1-20688-59358785-23 2017-06-05 16:32:05.260137052 +0000 UTC Received: from herokuapp.com (ec2-50-17-116-228.compute-1.amazonaws.com [50.17.116.228]) by ismtpd0005p1iad1.sendgrid.net (SG) with ESMTP id rwCEtjG9R0KtKJ0eiKYvGg Mon, 05 Jun 2017 16:32:05.221 +0000 (UTC) Date: Mon, 05 Jun 2017 16:32:05 +0000 From: Greg.mpls@gmail.com To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 56613 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 13570 X-Redmine-Issue-Author: Eregon X-Redmine-Issue-Assignee: X-Redmine-Sender: MSP-Greg X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS5x1DE2bWHHdJQnayFJ886xSHk1P+UKrBeU4Q qfCMEbPGOP8gkEXyFUKReivsOnagk4WeviX/JzGP5d+ehLUhmTJ4J5xpxv4o/3JkF0flyJT9oHKtM1 cPSVQZT3R8SKqPiNZiOvSHOLuw1pH4Bn8yXUPB3TCHxTUWIaS3IWbWRZYQ== X-ML-Name: ruby-core X-Mail-Count: 81582 Subject: [ruby-core:81582] [Ruby trunk Feature#13570] Using mkmf for ruby/spec C API specs X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #13570 has been updated by MSP-Greg (Greg L). nobu (Nobuyoshi Nakada) wrote: > test-spec runs fine on AppVeyor, test/ruby/test_rubyoptions.rb has a failure when locale and filesystem encodings differ. > Another problem is that it consumes 15 min, vs 8 min without tests. Thank you for working on that (in addition to everything else you do). MinGW has the same failure, as discussed previously. In my test results log, failures jumped from 5 to 6. That's when I decided to remove the chcp and RUBYOPT changes from my build code. Re my MinGW test-all, I guess my goals were/are: 1. It completes 2. Consistent failures/errors 3. Minimize skips 4. Consistent tests/assertions 5. WHY DOES THIS TAKE SO LONG / parallel test I haven't gotten to 5... ---------------------------------------- Feature #13570: Using mkmf for ruby/spec C API specs https://bugs.ruby-lang.org/issues/13570#change-65286 * Author: Eregon (Benoit Daloze) * Status: Assigned * Priority: Normal * Assignee: cruby-windows * Target version: ---------------------------------------- Hello all, I am thinking to use mkmf to compile the C API specs. https://github.com/ruby/ruby/blob/trunk/spec/rubyspec/optional/capi/spec_helper.rb is getting pretty complex and hard to maintain. I have a few questions: * Does mkmf works well on Windows? * What is a good way to compile a single .c file with mkmf to a given library file in another directory? I tried this but I am not sure it's correct: ~~~ ruby def compile_extension(name) objdir = object_path ext = "#{name}_spec" lib = "#{objdir}/#{ext}.#{RbConfig::CONFIG['DLEXT']}" require 'mkmf' # TODO: probably best to use a subprocess to avoid polluting the namespace Dir.chdir(objdir) do $srcs = ["#{extension_path}/#{ext}.c"] $objs = ["#{extension_path}/#{ext}.o"] # should probably be in objdir but that does not seem to work create_makefile(ext) system "make" end lib end ~~~ Alternatively, we can copy the needed files to a temporary directory, build there and copy the shared library back. It's a bit more work but not a big deal either. ---Files-------------------------------- spec_helper.rb (2.22 KB) spec_helper.rb (2.24 KB) -- https://bugs.ruby-lang.org/