From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-3.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,SPF_PASS,T_DKIM_INVALID,T_RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id E3AFF209FD for ; Mon, 5 Jun 2017 08:03:13 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id A9B76120766; Mon, 5 Jun 2017 17:03:10 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id 0793A120755 for ; Mon, 5 Jun 2017 17:03:08 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=6BZjqlOdvCaw7hXrB85hcAOpVJs=; b=KX6TepVtIVbli7Im7b Aj1TWguDisY6ztQjjxk6jKsmK8nlVEJUSrqtfUzdbllshXh9wNZmnn7bw9mPSExI kLUeG7aGBQlA+bb4vBFnEtBCLAAfBSBbSE/qrHe+Fe7bfo7Qw6DdOTPxy+yZUHum 07GdljLF1hpJp1dNH4K312+mY= Received: by filter1111p1mdw1.sendgrid.net with SMTP id filter1111p1mdw1-26715-59351039-20 2017-06-05 08:03:05.601736207 +0000 UTC Received: from herokuapp.com (ec2-54-161-238-60.compute-1.amazonaws.com [54.161.238.60]) by ismtpd0004p1iad1.sendgrid.net (SG) with ESMTP id SJxAn0hzTXKBxxuuhws0-A Mon, 05 Jun 2017 08:03:05.524 +0000 (UTC) Date: Mon, 05 Jun 2017 08:03:05 +0000 From: nobu@ruby-lang.org To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 56607 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 13570 X-Redmine-Issue-Author: Eregon X-Redmine-Issue-Assignee: X-Redmine-Sender: nobu X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS6mJ0Vtz1w5l2Hef5KvTm1qt7mkv5N4NcfFE8 4RIZG5aYxgj6CRISaqdZC0XS5duRHxrQoF9/N1gvmSjF32lsa7f6ysgTC0+3ZbOR3FjPlm3f9+HJ/5 wQqR/Zm4MsjE3mrebrZcxI6ajoNPLMeU7AojFvcPMHLfFHQC27igGaUd4g== X-ML-Name: ruby-core X-Mail-Count: 81576 Subject: [ruby-core:81576] [Ruby trunk Feature#13570] Using mkmf for ruby/spec C API specs X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #13570 has been updated by nobu (Nobuyoshi Nakada). test-spec runs fine on AppVeyor, test/ruby/test_rubyoptions.rb has a failure when locale and filesystem encodings differ. Another problem is that it consumes 15 min, vs 8 min without tests. ---------------------------------------- Feature #13570: Using mkmf for ruby/spec C API specs https://bugs.ruby-lang.org/issues/13570#change-65279 * Author: Eregon (Benoit Daloze) * Status: Assigned * Priority: Normal * Assignee: cruby-windows * Target version: ---------------------------------------- Hello all, I am thinking to use mkmf to compile the C API specs. https://github.com/ruby/ruby/blob/trunk/spec/rubyspec/optional/capi/spec_helper.rb is getting pretty complex and hard to maintain. I have a few questions: * Does mkmf works well on Windows? * What is a good way to compile a single .c file with mkmf to a given library file in another directory? I tried this but I am not sure it's correct: ~~~ ruby def compile_extension(name) objdir = object_path ext = "#{name}_spec" lib = "#{objdir}/#{ext}.#{RbConfig::CONFIG['DLEXT']}" require 'mkmf' # TODO: probably best to use a subprocess to avoid polluting the namespace Dir.chdir(objdir) do $srcs = ["#{extension_path}/#{ext}.c"] $objs = ["#{extension_path}/#{ext}.o"] # should probably be in objdir but that does not seem to work create_makefile(ext) system "make" end lib end ~~~ Alternatively, we can copy the needed files to a temporary directory, build there and copy the shared library back. It's a bit more work but not a big deal either. ---Files-------------------------------- spec_helper.rb (2.22 KB) spec_helper.rb (2.24 KB) -- https://bugs.ruby-lang.org/