From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-3.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_MED,SPF_PASS,T_DKIM_INVALID, T_RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 9DD3F2027C for ; Fri, 2 Jun 2017 14:33:44 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id CBC7C120751; Fri, 2 Jun 2017 23:33:41 +0900 (JST) Received: from o1678916x28.outbound-mail.sendgrid.net (o1678916x28.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id B14B8120731 for ; Fri, 2 Jun 2017 23:33:39 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=ykyW/GfV0NBJYhuVbkkdgz1R0AE=; b=RslI7d3Fv/H+KTV/M0 ogu01L7p3lHd5EpbAx6CrRJcyf+6dAM/bWqvIWXsxZ/3vVn2dLdgxv/4rQRydgtv Z1JKVeGRhmjHVMXJ7IA4tlRZ3MuMAy8iTi67HO/PF1V/Qs4XaVGjeKFamriWgU/n rjm+hnYRS3kT7ozDEPukfCt74= Received: by filter0950p1mdw1.sendgrid.net with SMTP id filter0950p1mdw1-1487-5931773C-1E 2017-06-02 14:33:32.121911698 +0000 UTC Received: from herokuapp.com (ec2-54-163-17-188.compute-1.amazonaws.com [54.163.17.188]) by ismtpd0002p1iad1.sendgrid.net (SG) with ESMTP id qkGijC5gSNmpTgnM46Wd1Q Fri, 02 Jun 2017 14:33:32.043 +0000 (UTC) Date: Fri, 02 Jun 2017 14:33:31 +0000 From: Greg.mpls@gmail.com To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 56557 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 13570 X-Redmine-Issue-Author: Eregon X-Redmine-Issue-Assignee: X-Redmine-Sender: MSP-Greg X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS75T5kPBYDwcjzPN9NGPAT+WtYvKgVvpUgrQU mB0jGdgjMTlrNWgoGhlKPkseTveDLI0PgpSGTdh3CXCjzaUkiCGa40bbPjgDBoynOhAMxRqloz27Bs W5jfzwzLkWjmVgGSutyjqHWwCPjeySAsUb+f2URM0rnQlehbD70vhbKT6w== X-ML-Name: ruby-core X-Mail-Count: 81527 Subject: [ruby-core:81527] [Ruby trunk Feature#13570] Using mkmf for ruby/spec C API specs X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #13570 has been updated by MSP-Greg (Greg L). Ran a MinGW build on `ruby 2.5.0dev 2017-06-02 58998`. Ran tests three ways: 1. `make test-spec` - pkg/install bin folder in path 2. `make test-spec` - pkg/install bin folder not in path 3. `mspec` - pkg/install bin folder in path All three ran with expected results. Although I'd prefer that `IO.copy_stream` be used, neither `fs.rb` or `spec_helper.rb` were patched to use it. Hence, good job and thanks... ---------------------------------------- Feature #13570: Using mkmf for ruby/spec C API specs https://bugs.ruby-lang.org/issues/13570#change-65233 * Author: Eregon (Benoit Daloze) * Status: Assigned * Priority: Normal * Assignee: cruby-windows * Target version: ---------------------------------------- Hello all, I am thinking to use mkmf to compile the C API specs. https://github.com/ruby/ruby/blob/trunk/spec/rubyspec/optional/capi/spec_helper.rb is getting pretty complex and hard to maintain. I have a few questions: * Does mkmf works well on Windows? * What is a good way to compile a single .c file with mkmf to a given library file in another directory? I tried this but I am not sure it's correct: ~~~ ruby def compile_extension(name) objdir = object_path ext = "#{name}_spec" lib = "#{objdir}/#{ext}.#{RbConfig::CONFIG['DLEXT']}" require 'mkmf' # TODO: probably best to use a subprocess to avoid polluting the namespace Dir.chdir(objdir) do $srcs = ["#{extension_path}/#{ext}.c"] $objs = ["#{extension_path}/#{ext}.o"] # should probably be in objdir but that does not seem to work create_makefile(ext) system "make" end lib end ~~~ Alternatively, we can copy the needed files to a temporary directory, build there and copy the shared library back. It's a bit more work but not a big deal either. ---Files-------------------------------- spec_helper.rb (2.22 KB) spec_helper.rb (2.24 KB) -- https://bugs.ruby-lang.org/