From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-3.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_MED,SPF_PASS,T_DKIM_INVALID, T_RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 0012E20D12 for ; Fri, 2 Jun 2017 09:15:22 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 1F1B3120769; Fri, 2 Jun 2017 18:15:21 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id 0ADB9120765 for ; Fri, 2 Jun 2017 18:15:18 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=B4CXx98EZlVp3gR7iGO4kH8c+EM=; b=ILLsn1j1saYWUzUR7/ 9KFRxu04DH28TbJU1qbZAOOvT1OzMAdoXFxNOMfn+fOmBbvi6+Pqpr32BZXFiDvF 2zovOaSjl2m+FrBtSxA5aKmIYFPC1+X5ZduGsHxLw1M/tcBetZPklcxFiyn4wNvB SHEJM2DYwH0n+iJa/ZLYbbz5U= Received: by filter1119p1mdw1.sendgrid.net with SMTP id filter1119p1mdw1-28811-59312C9F-1 2017-06-02 09:15:11.039122483 +0000 UTC Received: from herokuapp.com (ec2-54-160-142-233.compute-1.amazonaws.com [54.160.142.233]) by ismtpd0003p1iad1.sendgrid.net (SG) with ESMTP id M-bYBLHBQGyRLZBcTlDa5g Fri, 02 Jun 2017 09:15:10.982 +0000 (UTC) Date: Fri, 02 Jun 2017 09:15:10 +0000 From: eregontp@gmail.com To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 56551 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 13570 X-Redmine-Issue-Author: Eregon X-Redmine-Issue-Assignee: X-Redmine-Sender: Eregon X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS44ZrOAP1e1YvLLme94OlVc0fctSs20+CyHkO lYpqQkguGdCAPc6PNvJREuCRH9OfOIYpb8KtHaaBIIOEoxWUIs0f8mXWWn40im0gYXlVAYRck0cMEb e/hx+LkPKDqw+ze/vdlPbmKjDFpVNe734CItnEVa/BqxygZvwHvXKS68Qw== X-ML-Name: ruby-core X-Mail-Count: 81521 Subject: [ruby-core:81521] [Ruby trunk Feature#13570] Using mkmf for ruby/spec C API specs X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #13570 has been updated by Eregon (Benoit Daloze). File spec_helper.rb added Here is a version of the spec_helper.rb working on MRI 2.2 to trunk on Linux (and I would expect macOS as well). @Greg and @nobu: Could you test it on Windows? Then should I commit it? Or do we have a way to test CI (Travis + rubyci.org) before committing? ---------------------------------------- Feature #13570: Using mkmf for ruby/spec C API specs https://bugs.ruby-lang.org/issues/13570#change-65228 * Author: Eregon (Benoit Daloze) * Status: Assigned * Priority: Normal * Assignee: cruby-windows * Target version: ---------------------------------------- Hello all, I am thinking to use mkmf to compile the C API specs. https://github.com/ruby/ruby/blob/trunk/spec/rubyspec/optional/capi/spec_helper.rb is getting pretty complex and hard to maintain. I have a few questions: * Does mkmf works well on Windows? * What is a good way to compile a single .c file with mkmf to a given library file in another directory? I tried this but I am not sure it's correct: ~~~ ruby def compile_extension(name) objdir = object_path ext = "#{name}_spec" lib = "#{objdir}/#{ext}.#{RbConfig::CONFIG['DLEXT']}" require 'mkmf' # TODO: probably best to use a subprocess to avoid polluting the namespace Dir.chdir(objdir) do $srcs = ["#{extension_path}/#{ext}.c"] $objs = ["#{extension_path}/#{ext}.o"] # should probably be in objdir but that does not seem to work create_makefile(ext) system "make" end lib end ~~~ Alternatively, we can copy the needed files to a temporary directory, build there and copy the shared library back. It's a bit more work but not a big deal either. ---Files-------------------------------- spec_helper.rb (2.22 KB) spec_helper.rb (2.24 KB) -- https://bugs.ruby-lang.org/