From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-3.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_MED,SPF_PASS,T_DKIM_INVALID, T_RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 0F1B320D0A for ; Thu, 1 Jun 2017 16:21:53 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 48730120765; Fri, 2 Jun 2017 01:21:50 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id 6237C120764 for ; Fri, 2 Jun 2017 01:21:48 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=SriJWXKZWcNH0+AlkLn01vWJpco=; b=RO4SFIKAOtnG/VjpAf choowkPN37VodkujfzaNeryij4BHsVufikM3HleJO+h3l1MLEk/KjGJPzw1yGxp2 CKG0u+eqbAdQipQ8P6DCp7voAAhK44k4fBBpGu99Nc/ZARbGo7VUHGlt9RclNUbl toOoHd+ORLWtFq6N8q3Cz+4Yc= Received: by filter1101p1mdw1.sendgrid.net with SMTP id filter1101p1mdw1-6210-59303F18-22 2017-06-01 16:21:44.289676008 +0000 UTC Received: from herokuapp.com (ec2-54-160-142-233.compute-1.amazonaws.com [54.160.142.233]) by ismtpd0003p1iad1.sendgrid.net (SG) with ESMTP id NpyVBiGyRAuKmdSvyaTLZA Thu, 01 Jun 2017 16:21:44.232 +0000 (UTC) Date: Thu, 01 Jun 2017 16:21:44 +0000 From: eregontp@gmail.com To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 56540 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 13570 X-Redmine-Issue-Author: Eregon X-Redmine-Issue-Assignee: X-Redmine-Sender: Eregon X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS7crNA/PDL7afORW7pgWDwktJ+8nsUVGFP5+c xLmZu+3H+bho1+bErWgEi8R3p2WaKMi9uuJmo02ePPco4D8r/rAviPbsqEzpWyEK1JTKIMjW9NC8p4 Z9hULJVybLnSHtJBZBPaL4d4LuFWw6DItJi3G0SWN10TLe53Pi4QlLKA1A== X-ML-Name: ruby-core X-Mail-Count: 81510 Subject: [ruby-core:81510] [Ruby trunk Feature#13570] Using mkmf for ruby/spec C API specs X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #13570 has been updated by Eregon (Benoit Daloze). MSP-Greg (Greg L) wrote: > Benoit, > > After screwing around with quite a bit of make code, I found the (simple) issue. The code in [Object.cp](https://github.com/ruby/ruby/blob/trunk/spec/mspec/lib/mspec/helpers/fs.rb#L3-L11) does not properly copy binary files on Windows. Oh, wow, thanks and nice find! MSpec's #cp should use "rb"/"wb" modes obviously. Would it work with that? > Hence, since we know the `src` and `dest` are on the same partition/drive, I used `File.rename` in `spec_helper.rb`. Below is a diff/patch file: I am not sure that's always the case, but thanks for the patch, I will try it. > Tests run with `-j` both via `make test-spec` and running `mspec`. Results of both are at [Ruby MinGW Test Results](https://msp-greg.github.io/file.mingw_test-all.html#test-spec-Failure-Error-Summary). Great! ---------------------------------------- Feature #13570: Using mkmf for ruby/spec C API specs https://bugs.ruby-lang.org/issues/13570#change-65217 * Author: Eregon (Benoit Daloze) * Status: Assigned * Priority: Normal * Assignee: cruby-windows * Target version: ---------------------------------------- Hello all, I am thinking to use mkmf to compile the C API specs. https://github.com/ruby/ruby/blob/trunk/spec/rubyspec/optional/capi/spec_helper.rb is getting pretty complex and hard to maintain. I have a few questions: * Does mkmf works well on Windows? * What is a good way to compile a single .c file with mkmf to a given library file in another directory? I tried this but I am not sure it's correct: ~~~ ruby def compile_extension(name) objdir = object_path ext = "#{name}_spec" lib = "#{objdir}/#{ext}.#{RbConfig::CONFIG['DLEXT']}" require 'mkmf' # TODO: probably best to use a subprocess to avoid polluting the namespace Dir.chdir(objdir) do $srcs = ["#{extension_path}/#{ext}.c"] $objs = ["#{extension_path}/#{ext}.o"] # should probably be in objdir but that does not seem to work create_makefile(ext) system "make" end lib end ~~~ Alternatively, we can copy the needed files to a temporary directory, build there and copy the shared library back. It's a bit more work but not a big deal either. ---Files-------------------------------- spec_helper.rb (2.22 KB) -- https://bugs.ruby-lang.org/