From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-3.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_MED,SPF_PASS,T_DKIM_INVALID, T_RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 6C83B1FD09 for ; Wed, 31 May 2017 22:25:59 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 24154120736; Thu, 1 Jun 2017 07:25:53 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id 9F962120733 for ; Thu, 1 Jun 2017 07:25:47 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=PIzHR30Z8uz7z3h4oTaoO8EFj7M=; b=pOJwsq0tGBXfahYDm6 UCz7Z+Ow9ZwvXolj4/mJWDZL849EvFV4UG14R9yuK4gH2ruwFRx1lRSGpZb/AS12 4fj32rnTbzhrBx7lxB1iHdACzESSvLFJYqBGLuzCGzav6+cB7pzlN2PWflYgJNEi jsMEjZzrWH7T57CM2Zl1S4Uvo= Received: by filter0646p1mdw1.sendgrid.net with SMTP id filter0646p1mdw1-16499-592F42E5-2D 2017-05-31 22:25:41.615070828 +0000 UTC Received: from herokuapp.com (ec2-54-92-181-91.compute-1.amazonaws.com [54.92.181.91]) by ismtpd0006p1iad1.sendgrid.net (SG) with ESMTP id irxgFOqbS7yDT9oNag9KUg Wed, 31 May 2017 22:25:41.581 +0000 (UTC) Date: Wed, 31 May 2017 22:25:41 +0000 From: Greg.mpls@gmail.com To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 56520 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 13570 X-Redmine-Issue-Author: Eregon X-Redmine-Issue-Assignee: X-Redmine-Sender: MSP-Greg X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS4L0a54/n2PhiHdninE4hGThIQvbT7goVIVfG GR7IL7N378npSdEn9HcOi5mLLxqsCN+CulYIDcttpjEtYNEbzsBCV8nJJQ4IspSss8ReX1qL4FQZgQ h0ZcrYXOSBKnJYZPb9pGNbfsR3eVENu/+AhuG2kOyTZ4/wcxE8/DjnLBww== X-ML-Name: ruby-core X-Mail-Count: 81490 Subject: [ruby-core:81490] [Ruby trunk Feature#13570] Using mkmf for ruby/spec C API specs X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #13570 has been updated by MSP-Greg (Greg L). Benoit, After screwing around with quite a bit of make code, I found the (simple) issue. The code in [Object.cp](https://github.com/ruby/ruby/blob/trunk/spec/mspec/lib/mspec/helpers/fs.rb#L3-L11) does not properly copy binary files on Windows. Hence, since we know the `src` and `dest` are on the same partition/drive, I used `File.rename` in `spec_helper.rb`. Below is a diff/patch file: ```diff --- spec_helper_orig.rb Mon May 29 13:34:22 2017 +++ spec_helper.rb Wed May 31 15:47:17 2017 @@ -18,11 +18,7 @@ def compile_extension(name) debug = false - run_mkmf_in_process = false - - if RUBY_NAME == 'truffleruby' - run_mkmf_in_process = true - end + run_mkmf_in_process = RUBY_NAME == 'truffleruby' ext = "#{name}_spec" lib = "#{object_path}/#{ext}.#{RbConfig::CONFIG['DLEXT']}" @@ -61,7 +57,7 @@ raise "make failed:\n#{output}" unless $?.success? $stderr.puts output if debug - cp File.basename(lib), lib + File.rename File.basename(lib), lib end ensure rm_r tmpdir unless debug ``` Tests run with `-j` both via `make test-spec` and running `mspec`. Results of both are at [Ruby MinGW Test Results](https://msp-greg.github.io/file.mingw_test-all.html#test-spec-Failure-Error-Summary). Thanks for the work. ---------------------------------------- Feature #13570: Using mkmf for ruby/spec C API specs https://bugs.ruby-lang.org/issues/13570#change-65198 * Author: Eregon (Benoit Daloze) * Status: Assigned * Priority: Normal * Assignee: cruby-windows * Target version: ---------------------------------------- Hello all, I am thinking to use mkmf to compile the C API specs. https://github.com/ruby/ruby/blob/trunk/spec/rubyspec/optional/capi/spec_helper.rb is getting pretty complex and hard to maintain. I have a few questions: * Does mkmf works well on Windows? * What is a good way to compile a single .c file with mkmf to a given library file in another directory? I tried this but I am not sure it's correct: ~~~ ruby def compile_extension(name) objdir = object_path ext = "#{name}_spec" lib = "#{objdir}/#{ext}.#{RbConfig::CONFIG['DLEXT']}" require 'mkmf' # TODO: probably best to use a subprocess to avoid polluting the namespace Dir.chdir(objdir) do $srcs = ["#{extension_path}/#{ext}.c"] $objs = ["#{extension_path}/#{ext}.o"] # should probably be in objdir but that does not seem to work create_makefile(ext) system "make" end lib end ~~~ Alternatively, we can copy the needed files to a temporary directory, build there and copy the shared library back. It's a bit more work but not a big deal either. ---Files-------------------------------- spec_helper.rb (2.22 KB) -- https://bugs.ruby-lang.org/