From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-3.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_MED,SPF_PASS,T_DKIM_INVALID, T_RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id E5CCA20D0A for ; Mon, 29 May 2017 15:33:37 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id B92F31207A6; Tue, 30 May 2017 00:33:35 +0900 (JST) Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id AC6031207A3 for ; Tue, 30 May 2017 00:33:33 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=Dhj2JeABWbWbI3Vv7AKpQulmhMs=; b=HVBNIfllXS8flm1XSQ Cx6wEPffsKmLMleQgFQSnYp47v/8WYh/7m2UdjL49alavBdmEpxiAZXuGqfym9YZ my78QfTQ3f8kPyJBM+TBqpa6fQ1PbUUYvCu4jelBuTYFlM0RSOQOTxEqBxntUknk uiRqB1R4TGA7cvHe2aGVkL6AM= Received: by filter0793p1mdw1.sendgrid.net with SMTP id filter0793p1mdw1-24828-592C3F37-A0 2017-05-29 15:33:11.921207812 +0000 UTC Received: from herokuapp.com (ec2-54-167-29-171.compute-1.amazonaws.com [54.167.29.171]) by ismtpd0006p1iad1.sendgrid.net (SG) with ESMTP id o0FVEQcCQ127WkHQkY62Hg for ; Mon, 29 May 2017 15:33:11.894 +0000 (UTC) Date: Mon, 29 May 2017 15:33:11 +0000 From: eregontp@gmail.com To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 56481 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 13570 X-Redmine-Issue-Author: Eregon X-Redmine-Sender: Eregon X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS4LgiMwxUTahOnRon2KV0RJ/2+JaFQOida6GC cslIn8Ne2Qm61taY6rz1imF/47UDa3PlzeV/PYkLmMdD+5PEJGzFcvwHfn/A/GSiEdSc/81zG/Dien haupHb9Gox6q1f7paJ5HAnGwuKNADw6ijhSvRJ+1NWnQ/Nvdj4ubP/2UIw== X-ML-Name: ruby-core X-Mail-Count: 81455 Subject: [ruby-core:81455] [Ruby trunk Feature#13570] Using mkmf for ruby/spec C API specs X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #13570 has been updated by Eregon (Benoit Daloze). File spec_helper.rb added I attach here the current version of the spec_helper.rb doing the compilation of extensions. It seems to now work correctly for out-of-source builds, and with an extra hack uses the right ruby in the Makefile (RbConfig.ruby in ./rbconfig.rb is just incorrect for built but not installed ruby). I found very confusing the effect that $extmf can have, I wished MRI used a simpler mechanism to detect if ruby was installed or not. Is it so important nowadays to be able to test without "make install"? Could I ask some help for making this run correctly on Windows? I would like if possible something not too hacky. The old way to compile extensions was un-maintainable due to its complexity. ---------------------------------------- Feature #13570: Using mkmf for ruby/spec C API specs https://bugs.ruby-lang.org/issues/13570#change-65157 * Author: Eregon (Benoit Daloze) * Status: Closed * Priority: Normal * Assignee: * Target version: ---------------------------------------- Hello all, I am thinking to use mkmf to compile the C API specs. https://github.com/ruby/ruby/blob/trunk/spec/rubyspec/optional/capi/spec_helper.rb is getting pretty complex and hard to maintain. I have a few questions: * Does mkmf works well on Windows? * What is a good way to compile a single .c file with mkmf to a given library file in another directory? I tried this but I am not sure it's correct: ~~~ ruby def compile_extension(name) objdir = object_path ext = "#{name}_spec" lib = "#{objdir}/#{ext}.#{RbConfig::CONFIG['DLEXT']}" require 'mkmf' # TODO: probably best to use a subprocess to avoid polluting the namespace Dir.chdir(objdir) do $srcs = ["#{extension_path}/#{ext}.c"] $objs = ["#{extension_path}/#{ext}.o"] # should probably be in objdir but that does not seem to work create_makefile(ext) system "make" end lib end ~~~ Alternatively, we can copy the needed files to a temporary directory, build there and copy the shared library back. It's a bit more work but not a big deal either. ---Files-------------------------------- spec_helper.rb (2.22 KB) -- https://bugs.ruby-lang.org/