From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-3.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_MED,SPF_PASS,T_DKIM_INVALID, T_RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id D184D20D09 for ; Sat, 27 May 2017 18:39:18 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 7DC1E120754; Sun, 28 May 2017 03:39:15 +0900 (JST) Received: from o1678916x28.outbound-mail.sendgrid.net (o1678916x28.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id 558EC120733 for ; Sun, 28 May 2017 03:39:13 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=jo/U9qkoWgbtSMePb4HB6gnmh6c=; b=CTQMUdkV6s0zBLUyHc TZ9aefaADWldxlAsbQh+gAWz0kUfQ6D9hmNcWS82VBX8jugT3a0t+nzwNmIpFIGw cVo9u1t+lC+ZraHdI13AG0oicjsdZ8Dizt7L24JITDEfT3hc/oD57h5RO3889Wej M0A1HeQ/IAtg5coLIymUK9vEQ= Received: by filter0531p1mdw1.sendgrid.net with SMTP id filter0531p1mdw1-27022-5929C7CD-5 2017-05-27 18:39:09.170758416 +0000 UTC Received: from herokuapp.com (ec2-54-146-21-181.compute-1.amazonaws.com [54.146.21.181]) by ismtpd0005p1iad1.sendgrid.net (SG) with ESMTP id BrvueNDQQimeU56cHTPqrQ Sat, 27 May 2017 18:39:09.170 +0000 (UTC) Date: Sat, 27 May 2017 18:39:09 +0000 From: Greg.mpls@gmail.com To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 56452 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 13591 X-Redmine-Issue-Author: MSP-Greg X-Redmine-Issue-Assignee: Eregon X-Redmine-Sender: MSP-Greg X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS6X7SJaW66sniXL/LYuz5FUkErIcwd9Pv7MAZ t7vZBCxk1+VZEoeLa/W9CQCwljhc5HSUd2nYCRj1KcXZH/6R6As+raItA7a337APyiaacj3jV74pf2 Ye//rtNXDw8LbcAyXIj0eqaHqdhAoqzGOGo2TEbMGVeNh2GzALoTJeIdJA== X-ML-Name: ruby-core X-Mail-Count: 81423 Subject: [ruby-core:81423] [Ruby trunk Bug#13591] spec/rubyspec/core/time/zone_spec - Windows does not support ENV['TZ'] X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #13591 has been updated by MSP-Greg (Greg L). Usaku, You are correct. Linked from the page you mentioned is [_tzset](https://msdn.microsoft.com/en-us/library/90s5c885.aspx). This (sort of) doc's what ENV['TZ'] can be set to. >From my testing, the strings can be anything. I called the following with several strings. ``` puts "TZ DST SST" def tz_test(s) dst = [2017, 6, 1, 12, 0] # daylight - June sst = [2017, 1, 1, 12, 0] # standard - January ENV['TZ'] = s puts "#{s.ljust(10)} #{(Time.new(*dst).utc_offset/3600).to_s.rjust(4)} #{(Time.new(*sst).utc_offset/3600).to_s.rjust(4)}" end ``` output below. ``` TZ DST SST hello-foo 1 0 hello+foo 1 0 1,2 0 0 Sun,Fri,2 1 0 12 0 0 -1aaa 1 0 aaa+8 -8 -8 AAA+8 -8 -8 aaa+8bbb -7 -8 AAAA+8BBBB 1 0 aaa-8 8 8 AAA-8 8 8 aaa-8bbb 9 8 AAAA-8BBBB 1 0 ``` A classic case of a function that assumes you have validated the input, and, if not, be prepared for anything. My opinion, Ruby mingw and mswin builds are fine, the `_tzset` function is expecting validation that ruby can't or shouldn't do. There's a gem for that... ---------------------------------------- Bug #13591: spec/rubyspec/core/time/zone_spec - Windows does not support ENV['TZ'] https://bugs.ruby-lang.org/issues/13591#change-65134 * Author: MSP-Greg (Greg L) * Status: Feedback * Priority: Normal * Assignee: Eregon (Benoit Daloze) * Target version: * ruby -v: ruby 2.5.0dev (2017-05-27 trunk 58911) [x64-mswin64_140] * Backport: 2.2: UNKNOWN, 2.3: UNKNOWN, 2.4: UNKNOWN ---------------------------------------- Windows does not support ENV['TZ'], so it should be removed from rspec tests. See [GitHub PR 1627](https://github.com/ruby/ruby/pull/1627) -- https://bugs.ruby-lang.org/