From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS4713 221.184.0.0/13 X-Spam-Status: No, score=-3.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_MED,SPF_PASS,T_DKIM_INVALID, T_RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by dcvr.yhbt.net (Postfix) with ESMTP id 74C601FD09 for ; Sat, 27 May 2017 09:33:50 +0000 (UTC) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 31914120754; Sat, 27 May 2017 18:33:47 +0900 (JST) Received: from o1678916x28.outbound-mail.sendgrid.net (o1678916x28.outbound-mail.sendgrid.net [167.89.16.28]) by neon.ruby-lang.org (Postfix) with ESMTPS id 82BFD12074F for ; Sat, 27 May 2017 18:33:44 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=NSOW2r3/xKFdYTC2NDYBvdI+Cts=; b=vh1XIdCW74dc5UQ6Ij UUe6OHYsHU8RoKBfOqpmWI/8+OGsdQplsmtjfOfhNtMDpposy55lOFTfqB/grsKV qVsVeIgFUj4FY9R2Dw6la9z2NLZs4gKe1vM8SfFefH1FCQ21+5OJ0LHIhKKom/4p oOcayheEUoByr54EKUINlsVXI= Received: by filter0486p1mdw1.sendgrid.net with SMTP id filter0486p1mdw1-3819-592947F1-34 2017-05-27 09:33:37.98412305 +0000 UTC Received: from herokuapp.com (ec2-23-23-4-12.compute-1.amazonaws.com [23.23.4.12]) by ismtpd0003p1iad1.sendgrid.net (SG) with ESMTP id 42HAL_P9RReYT2mryOQ68w Sat, 27 May 2017 09:33:37.978 +0000 (UTC) Date: Sat, 27 May 2017 09:33:37 +0000 From: eregontp@gmail.com To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 56444 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 13591 X-Redmine-Issue-Author: MSP-Greg X-Redmine-Issue-Assignee: Eregon X-Redmine-Sender: Eregon X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS7d6f/0e0A1PfREVDRp39fjssU6y78YADIf+6 E5QcndjTnossW6u0xwbRDBx87BWzKnY5xl7OSwwVOtXkTaJonhVUatCSgzmFyHg9u9qXNlAWMeBVRG 71xrF9V8HJwBCLT5WdbLa9QCDngzOm7xdGDh9R9G7VxSjQf7oOXx3tGvWg== X-ML-Name: ruby-core X-Mail-Count: 81415 Subject: [ruby-core:81415] [Ruby trunk Bug#13591] spec/rubyspec/core/time/zone_spec - Windows does not support ENV['TZ'] X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #13591 has been updated by Eregon (Benoit Daloze). Assignee set to Eregon (Benoit Daloze) FWIW the patch looks OK to me, I think we should merge it. This might be a difference between the different configuration of Windows builds. Testing for invalid timezones is rather difficult, some platforms behave differently, and this test had to be refined a couple times to work on all Linux CIs. MSP-Greg (Greg L) wrote: > I'll have a look at your code, see if I can determine whats going on. Believe me, I did a couple of builds, and it kept failing... Could you just post a failing stacktrace here when running the test in isolation? You can do so with $ make test-rubyspec MSPECOPT="-e bad spec/rubyspec/core/time/zone_spec.rb" or $ spec/mspec/bin/mspec -e bad spec/rubyspec/core/time/zone_spec.rb if the built ruby is on $PATH. ---------------------------------------- Bug #13591: spec/rubyspec/core/time/zone_spec - Windows does not support ENV['TZ'] https://bugs.ruby-lang.org/issues/13591#change-65127 * Author: MSP-Greg (Greg L) * Status: Rejected * Priority: Normal * Assignee: Eregon (Benoit Daloze) * Target version: * ruby -v: ruby 2.5.0dev (2017-05-27 trunk 58911) [x64-mswin64_140] * Backport: 2.2: UNKNOWN, 2.3: UNKNOWN, 2.4: UNKNOWN ---------------------------------------- Windows does not support ENV['TZ'], so it should be removed from rspec tests. See [GitHub PR 1627](https://github.com/ruby/ruby/pull/1627) -- https://bugs.ruby-lang.org/