From: cben@redhat.com
To: ruby-core@ruby-lang.org
Subject: [ruby-core:81154] [Ruby trunk Feature#10674] Net::HTTP retries idempotent requests once after a timeout, but its not configurable
Date: Sun, 14 May 2017 11:51:03 +0000 [thread overview]
Message-ID: <redmine.journal-64806.20170514115102.f2523694ef7560cc@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-10674.20141229151053@ruby-lang.org
Issue #10674 has been updated by cben (Beni Cherniavsky-Paskin).
Can confirm on 2.4.1.
The responsible code is here: https://github.com/ruby/ruby/blob/v2_4_1/lib/net/http.rb#L1468
I'm thinking of making a simple patch adding a boolean "#retry=". Application or higher-level gems can then implement any retry logic...
----------------------------------------
Feature #10674: Net::HTTP retries idempotent requests once after a timeout, but its not configurable
https://bugs.ruby-lang.org/issues/10674#change-64806
* Author: jlecour (Jérémy Lecour)
* Status: Open
* Priority: Normal
* Assignee: drbrain (Eric Hodel)
* Target version:
----------------------------------------
Hi,
I've noticed that Net::HTTP retries idempotent requests once after a time-out. It seems to adhere to the RFC 2616 (http://tools.ietf.org/html/rfc2616), but it is not always the best thing to do.
When you don't know exactly how a remote web service works, it may be wise to retry after a time-out.
But when you know that a retry won't change anything, it should be possible to disable this automatic retry. Otherwise, the server will have to deal with 2 requests (instead of 1) and the client will effectively time-out twice later than expected (time for the first and second time-out).
Having a basic "#retry=" (like we have "#read_timeout=" or "#open_timeout" would be good first step.
The value could be a simple boolean, or even an integer for the maximum number of retries.
The "Retry" middleware in Faraday has a more comprehensive feature set with max retries, exponential back-off, … : https://github.com/lostisland/faraday/blob/master/lib/faraday/request/retry.rb
--
https://bugs.ruby-lang.org/
next prev parent reply other threads:[~2017-05-14 11:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <redmine.issue-10674.20141229151053@ruby-lang.org>
2014-12-29 15:10 ` [ruby-core:67206] [ruby-trunk - Feature #10674] [Open] Net::HTTP retries idempotent requests once after a timeout, but its not configurable jeremy.lecour
2015-11-20 21:42 ` [ruby-core:71614] [Ruby trunk - Feature #10674] " garett.shulman
2017-05-14 11:51 ` cben [this message]
2017-07-14 8:51 ` [ruby-core:82059] [Ruby trunk Feature#10674][Assigned] " naruse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.ruby-lang.org/en/community/mailing-lists/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=redmine.journal-64806.20170514115102.f2523694ef7560cc@ruby-lang.org \
--to=ruby-core@ruby-lang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).