From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id 4E9DA1B6040E for ; Sun, 26 Feb 2017 03:48:33 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id 2B674B5D892 for ; Sun, 26 Feb 2017 04:19:06 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id 20EC418D1D82 for ; Sun, 26 Feb 2017 04:19:06 +0900 (JST) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 5155512065F; Sun, 26 Feb 2017 04:19:04 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o1678948x4.outbound-mail.sendgrid.net (o1678948x4.outbound-mail.sendgrid.net [167.89.48.4]) by neon.ruby-lang.org (Postfix) with ESMTPS id 24FD2120655 for ; Sun, 26 Feb 2017 04:18:58 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=n9hLwIgvsxOTBSFimIpR6i7l3j8=; b=am1WdFG7V4fWuZNCe/ ZgMBmbNVJyILxnrA2dpwjXW69qoL5iTjYxH4QfboEStJj7YvbtHmIhO/3ryCkpdK m92EiLsng8iSH9SSTPHt9FT4w+Kp02/LmX2kdgddnV3++uVVujFmqgLgqu4sFTXg XQeZbGA9Djru9RoINCcTz94oM= Received: by filter0643p1mdw1.sendgrid.net with SMTP id filter0643p1mdw1-25938-58B1D89E-3C 2017-02-25 19:18:54.926275687 +0000 UTC Received: from herokuapp.com (ec2-54-234-156-114.compute-1.amazonaws.com [54.234.156.114]) by ismtpd0004p1iad1.sendgrid.net (SG) with ESMTP id hpBngWrsTh20raNYFnepSQ Sat, 25 Feb 2017 19:18:54.951 +0000 (UTC) Date: Sat, 25 Feb 2017 19:18:54 +0000 From: shevegen@gmail.com To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 54705 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 13249 X-Redmine-Issue-Author: abotalov X-Redmine-Sender: shevegen X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS5XMhicPysBGtrFz//Cm9bLgeVGzHjD3XL6Kq iiN0KvJQCS83LUnUF8JR5ZH+zQErk3Z44j6gYDteMhWqOZZBtYEcPQoJi1Z0Zc4f6hFg6hpK17cLqb zOn38wkV6vLfJ2PKy1KzfQPgg+vHhHShThSaWeHPRF3vdnoaoJdnv1lSiQ== X-ML-Name: ruby-core X-Mail-Count: 79774 Subject: [ruby-core:79774] [Ruby trunk Bug#13249] Access modifiers don't have an effect inside class methods in Ruby >= 2.3 X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #13249 has been updated by Robert A. Heiler. The examples confuse me a bit. Does private actually make sense on any class-method / singleton method? I understand it as a limitation for methods on the class, where outside calls are not allowed, only internal ones (though ruby allows one to bypass these anyway via .send). I am also confused by the second example: class C def self.foo private def bar end end end C.foo C.new.bar Is that not equivalent to private def self.bar ? So why would this work on the C.new.bar() level? It is however had interesting that this worked on 2.2 and below but was changed past that point. ---------------------------------------- Bug #13249: Access modifiers don't have an effect inside class methods in Ruby >= 2.3 https://bugs.ruby-lang.org/issues/13249#change-63199 * Author: Andrei Botalov * Status: Open * Priority: Normal * Assignee: * Target version: * ruby -v: 2.3.0, 2.4.0 * Backport: 2.2: UNKNOWN, 2.3: UNKNOWN, 2.4: UNKNOWN ---------------------------------------- Simple example: ~~~ ruby class C def self.foo private def bar end end end C.foo C.new.bar ~~~ This code runs fine on Ruby 2.3 and Ruby 2.4. It raises NoMethodError on Ruby 2.2 and prior versions. I would expect an error to be raised. Here is some code that actually uses private access modifier inside a class method - https://github.com/evolve75/RubyTree/blob/db48c35b0a3b96e4da473b095cc00e454d8a9996/lib/tree/utils/camel_case_method_handler.rb#L60 By the way, this code raises an error as expected on Ruby 2.3 and Ruby 2.4: ~~~ ruby class C def self.foo private def bar end end end C.foo C.new.bar ~~~ -- https://bugs.ruby-lang.org/