From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id 9FFB31B20013 for ; Fri, 16 Dec 2016 09:45:36 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id BAC58B5D957 for ; Fri, 16 Dec 2016 10:15:32 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id E0B7C18D1D87 for ; Fri, 16 Dec 2016 10:15:32 +0900 (JST) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id D1ACC120683; Fri, 16 Dec 2016 10:15:32 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o10.shared.sendgrid.net (o10.shared.sendgrid.net [173.193.132.135]) by neon.ruby-lang.org (Postfix) with ESMTPS id 8A57A12067B for ; Fri, 16 Dec 2016 10:15:28 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=NUCes6lt8VD9mR37E927K4PMkk8=; b=YngKGRces16yeXYNFY l6qpA7yD6E1uRVIDU2LGBf+gzf+lyy7Q5NLu7g7pkO/ZhG4ENEg2DlfZ9vRVVx3M gkttcCzWkvcO70Qm/XGUasZZR4qcH9UbBW7yW2ODm5UwGWObYRW29zcP6ytUlUC3 EcwLkwr4pcaXvdwafRKQA3Y60= Received: by filter0533p1mdw1.sendgrid.net with SMTP id filter0533p1mdw1-26036-5853402C-3D 2016-12-16 01:15:24.906620418 +0000 UTC Received: from herokuapp.com (ec2-54-90-184-150.compute-1.amazonaws.com [54.90.184.150]) by ismtpd0002p1iad1.sendgrid.net (SG) with ESMTP id QgmMOvrFS0-Ns0pn-HFNvQ Fri, 16 Dec 2016 01:15:24.895 +0000 (UTC) Date: Fri, 16 Dec 2016 01:15:24 +0000 From: nobu@ruby-lang.org To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 53565 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 13040 X-Redmine-Issue-Author: lemsx1 X-Redmine-Sender: nobu X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS7PB7iVn9JH51IoaDtzEuoTALP7RKBT+S5Ws4 4MfAics0e5iUDNjKjHpKCVADFX/DwrZmhIaet5+3uAqED1uqACnJcid+D8DiAV33F7OVvglmgn0WHQ jVb70z20DqggCsKEnrWRtF9+wgqmBaJDV0E0wQsoAatAIeiC++mMtwXuXQ== X-ML-Name: ruby-core X-Mail-Count: 78674 Subject: [ruby-core:78674] [Ruby trunk Bug#13040][Feedback] syslog/logger uses "require 'logger'" which is interpreted as circular dependency X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #13040 has been updated by Nobuyoshi Nakada. Status changed from Open to Feedback ---------------------------------------- Bug #13040: syslog/logger uses "require 'logger'" which is interpreted as circular dependency https://bugs.ruby-lang.org/issues/13040#change-62052 * Author: Luis Mondesi * Status: Feedback * Priority: Normal * Assignee: * Target version: * ruby -v: ruby 2.3.1p112 (2016-04-26 revision 54768) [x86_64-linux] * Backport: 2.1: UNKNOWN, 2.2: UNKNOWN, 2.3: UNKNOWN ---------------------------------------- while using the 'syslog/logger' require from Ruby it works well, however if one tries to use it via "test" it complaints about circular require and the constant "Logger" not defined. After a little digging, I realized that 'syslog/logger' has a line that says require 'logger' which could mean itself! The fix is to use require_relative '../logger' as this is what it intends in order to piggy back on Logger: Current code for syslog/logger: 1. # frozen_string_literal: false 2. require 'syslog' 3. require 'logger' Fixed code: 1. # frozen_string_literal: false 2. require 'syslog' 3. require_relative '../logger' -- https://bugs.ruby-lang.org/