From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id ACD921B20013 for ; Fri, 16 Dec 2016 09:45:26 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id BFC48B5D90A for ; Fri, 16 Dec 2016 10:15:22 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id DB06818CC7F9 for ; Fri, 16 Dec 2016 10:15:22 +0900 (JST) Received: from neon.ruby-lang.org (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id C4577120691; Fri, 16 Dec 2016 10:15:21 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o2.heroku.sendgrid.net (o2.heroku.sendgrid.net [67.228.50.55]) by neon.ruby-lang.org (Postfix) with ESMTPS id D152A12067B for ; Fri, 16 Dec 2016 10:15:17 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=UVZDo69ixDn3XCrOcoDWeCCdIvU=; b=qgLvHer98zcJdHSs/p y0CLwUjx5jMjCq6c/CvQjXdFqicv5HEtR+SGGbioJxmgvCjUeeJn3o4fZj8ji8d3 JC5bNaPDD+eAaeih5GjyMUhRyk4azWH6frph1vxoZX8geqXTnfRnKUcsz0r/6ICn RpONpiQI2aMX2g8o4q7lZmae8= Received: by filter0459p1mdw1.sendgrid.net with SMTP id filter0459p1mdw1-31685-58534021-7 2016-12-16 01:15:13.258138488 +0000 UTC Received: from herokuapp.com (ec2-54-90-184-150.compute-1.amazonaws.com [54.90.184.150]) by ismtpd0004p1iad1.sendgrid.net (SG) with ESMTP id CI73mmyqS8CdE7U7pVs5hA Fri, 16 Dec 2016 01:15:13.226 +0000 (UTC) Date: Fri, 16 Dec 2016 01:15:13 +0000 From: nobu@ruby-lang.org To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 53564 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 13040 X-Redmine-Issue-Author: lemsx1 X-Redmine-Sender: nobu X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS5zC2iI1/2uxUtcUli+LAeA6i8YAye14kj9Ue gdpD+jv7n+lPMUJv9MVTrkF2BBYu/4mj1VozqFZPSckcqoA7/BmDLe7uQb7RAUeOf3wa9rks+OGk+6 Se/lCYknPXg3pL4KkY4teOj1OtWjVE1xUZ+xtT7g5GdHXm1jMKJ/xCcfTw== X-ML-Name: ruby-core X-Mail-Count: 78673 Subject: [ruby-core:78673] [Ruby trunk Bug#13040] syslog/logger uses "require 'logger'" which is interpreted as circular dependency X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #13040 has been updated by Nobuyoshi Nakada. 'syslog/logger.rb' and 'logger.rb' are different files. What do you mean by "test"? ---------------------------------------- Bug #13040: syslog/logger uses "require 'logger'" which is interpreted as circular dependency https://bugs.ruby-lang.org/issues/13040#change-62051 * Author: Luis Mondesi * Status: Open * Priority: Normal * Assignee: * Target version: * ruby -v: ruby 2.3.1p112 (2016-04-26 revision 54768) [x86_64-linux] * Backport: 2.1: UNKNOWN, 2.2: UNKNOWN, 2.3: UNKNOWN ---------------------------------------- while using the 'syslog/logger' require from Ruby it works well, however if one tries to use it via "test" it complaints about circular require and the constant "Logger" not defined. After a little digging, I realized that 'syslog/logger' has a line that says require 'logger' which could mean itself! The fix is to use require_relative '../logger' as this is what it intends in order to piggy back on Logger: Current code for syslog/logger: 1. # frozen_string_literal: false 2. require 'syslog' 3. require 'logger' Fixed code: 1. # frozen_string_literal: false 2. require 'syslog' 3. require_relative '../logger' -- https://bugs.ruby-lang.org/