ruby-core@ruby-lang.org archive (unofficial mirror)
 help / color / mirror / Atom feed
From: akr@fsij.org
To: ruby-core@ruby-lang.org
Subject: [ruby-core:77990] [Ruby trunk Bug#11595][Rejected] Time#utc? and Time#gmt? return misleading results based on $TZ
Date: Sat, 05 Nov 2016 16:09:03 +0000	[thread overview]
Message-ID: <redmine.journal-61327.20161105160903.21fa6b676c82e62e@ruby-lang.org> (raw)
In-Reply-To: redmine.issue-11595.20151014193359@ruby-lang.org

Issue #11595 has been updated by Akira Tanaka.

Status changed from Open to Rejected

Current behavior is intentional.

Time#utc? returns the mode of Time object, not the time zone offset is zero.

The mode affects several methods.

For example, Time#to_s generates "UTC" for UTC Time objects and
numeric timezone offset string for non-UTC Time objects.
The result of Time#utc? method means the difference of them.

```
% TZ=GMT ruby -e '
u = Time.utc(2000)
l = Time.local(2000)
p [u, u.utc?]
p [l, l.utc?]'       
[2000-01-01 00:00:00 UTC, true]
[2000-01-01 00:00:00 +0000, false]
```

----------------------------------------
Bug #11595: Time#utc? and Time#gmt? return misleading results based on $TZ
https://bugs.ruby-lang.org/issues/11595#change-61327

* Author: David Celis
* Status: Rejected
* Priority: Normal
* Assignee: Akira Tanaka
* ruby -v: ruby 2.2.3p173 (2015-08-18 revision 51636) [x86_64-darwin14]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
There is an issue with Time#utc? and its alias, Time#gmt?, that return misleading results based on the value of the TZ environment variable. It seems that the only way for a Time instance to return `true` for `utc?` is if you explicitly call `#utc` on it before:

~~~
ENV['TZ'] = 'UTC'
# => "UTC"
time = Time.now
# => 2015-10-14 19:30:00 +0000
time.utc?
# => false
time = time.utc
# => 2015-10-14 19:30:00 UTC
time.utc?
# => true
~~~

This seems misleading based on the value of $TZ being "UTC". The expected result for calling `Time.now.utc?` in this case would be `true`, as would that be expected for time zones that are considered links to "UTC" based on the [tzdata list](https://en.wikipedia.org/wiki/List_of_tz_database_time_zones). These include "UTC", "GMT", "Etc/UTC", "Etc/GMT", "Universal", etc.

---Files--------------------------------
time_utc.patch (927 Bytes)


-- 
https://bugs.ruby-lang.org/

      parent reply	other threads:[~2016-11-05 15:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <redmine.issue-11595.20151014193359@ruby-lang.org>
2015-10-14 19:34 ` [ruby-core:71089] [Ruby trunk - Bug #11595] [Open] Time#utc? and Time#gmt? return misleading results based on $TZ me
2015-11-30 13:24 ` [ruby-core:71753] [Ruby trunk - Bug #11595] " yasuhiro6194
2015-11-30 13:27 ` [ruby-core:71754] " yasuhiro6194
2015-11-30 16:55 ` [ruby-core:71759] " me
2016-01-23 18:55 ` [ruby-core:73320] " andrew
2016-11-05 16:09 ` akr [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.ruby-lang.org/en/community/mailing-lists/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=redmine.journal-61327.20161105160903.21fa6b676c82e62e@ruby-lang.org \
    --to=ruby-core@ruby-lang.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).