[ruby-core:77709] [Ruby trunk Misc#12863] Hash#compact! behavior different from the Active Support Hash#compact!

[ruby-core:77709] [Ruby trunk Misc#12863] Hash#compact! behavior different from the Active Support Hash#compact!

[csonpatki]

Issue #12863 has been reported by Prathamesh Sonpatki.

----------------------------------------
Misc #12863: Hash#compact! behavior different from the Active Support Hash#compact!
https://bugs.ruby-lang.org/issues/12863

* Author: Prathamesh Sonpatki
* Status: Open
* Priority: Normal
* Assignee: 
----------------------------------------
Hash#compact and Hash#compact! were added in https://bugs.ruby-lang.org/issues/11818 but the Hash#compact! is different from Active Support. Please check following snippet:

~~~ ruby
# Active Support
>> hash = { a: true, b: false, c: nil }
=> {:a=>true, :b=>false, :c=>nil}
>> hash.compact!
=> {:a=>true, :b=>false}
>> hash.compact!
=> nil

# Ruby dev

>> hash = { a: true, b: false, c: nil }
=> {:a=>true, :b=>false, :c=>nil}
>> hash.compact!
=> {:a=>true, :b=>false}
>> hash.compact!
=> {:a=>true, :b=>false}
>> 
~~~

@nobu Was it intentional to not return nil in case of compact! when none of the values are nil?





-- 
https://bugs.ruby-lang.org/

[ruby-core:77710] [Ruby trunk Misc#12863] Hash#compact! behavior different from the Active Support Hash#compact!

[zverok.offline]

Issue #12863 has been updated by Victor Shepelev.


What is the reason of returning `nil` in that case? I believe in standard containers all bang-versions always return self?

----------------------------------------
Misc #12863: Hash#compact! behavior different from the Active Support Hash#compact!
https://bugs.ruby-lang.org/issues/12863#change-60991

* Author: Prathamesh Sonpatki
* Status: Open
* Priority: Normal
* Assignee: 
----------------------------------------
Hash#compact and Hash#compact! were added in https://bugs.ruby-lang.org/issues/11818 but the Hash#compact! is different from Active Support. Please check following snippet:

~~~ ruby
# Active Support
>> hash = { a: true, b: false, c: nil }
=> {:a=>true, :b=>false, :c=>nil}
>> hash.compact!
=> {:a=>true, :b=>false}
>> hash.compact!
=> nil

# Ruby dev

>> hash = { a: true, b: false, c: nil }
=> {:a=>true, :b=>false, :c=>nil}
>> hash.compact!
=> {:a=>true, :b=>false}
>> hash.compact!
=> {:a=>true, :b=>false}
>> 
~~~

@nobu Was it intentional to not return nil in case of compact! when none of the values are nil?





-- 
https://bugs.ruby-lang.org/

[ruby-core:77711] [Ruby trunk Misc#12863] Hash#compact! behavior different from the Active Support Hash#compact!

[zverok.offline]

Issue #12863 has been updated by Victor Shepelev.


Hm, looks like returning `nil` (if nothing was dropped) is standard behavior of [Hash#reject!](https://ruby-doc.org/core-1.9.3/Hash.html#method-i-reject-21). Weird.

----------------------------------------
Misc #12863: Hash#compact! behavior different from the Active Support Hash#compact!
https://bugs.ruby-lang.org/issues/12863#change-60992

* Author: Prathamesh Sonpatki
* Status: Open
* Priority: Normal
* Assignee: 
----------------------------------------
Hash#compact and Hash#compact! were added in https://bugs.ruby-lang.org/issues/11818 but the Hash#compact! is different from Active Support. Please check following snippet:

~~~ ruby
# Active Support
>> hash = { a: true, b: false, c: nil }
=> {:a=>true, :b=>false, :c=>nil}
>> hash.compact!
=> {:a=>true, :b=>false}
>> hash.compact!
=> nil

# Ruby dev

>> hash = { a: true, b: false, c: nil }
=> {:a=>true, :b=>false, :c=>nil}
>> hash.compact!
=> {:a=>true, :b=>false}
>> hash.compact!
=> {:a=>true, :b=>false}
>> 
~~~

@nobu Was it intentional to not return nil in case of compact! when none of the values are nil?





-- 
https://bugs.ruby-lang.org/

[ruby-core:77712] [Ruby trunk Bug#12863] Hash#compact! behavior different from the Active Support Hash#compact!

[nobu]

Issue #12863 has been updated by Nobuyoshi Nakada.

Tracker changed from Misc to Bug
Backport set to 2.1: UNKNOWN, 2.2: UNKNOWN, 2.3: UNKNOWN

----------------------------------------
Bug #12863: Hash#compact! behavior different from the Active Support Hash#compact!
https://bugs.ruby-lang.org/issues/12863#change-60993

* Author: Prathamesh Sonpatki
* Status: Open
* Priority: Normal
* Assignee: 
* ruby -v: 
* Backport: 2.1: UNKNOWN, 2.2: UNKNOWN, 2.3: UNKNOWN
----------------------------------------
Hash#compact and Hash#compact! were added in https://bugs.ruby-lang.org/issues/11818 but the Hash#compact! is different from Active Support. Please check following snippet:

~~~ ruby
# Active Support
>> hash = { a: true, b: false, c: nil }
=> {:a=>true, :b=>false, :c=>nil}
>> hash.compact!
=> {:a=>true, :b=>false}
>> hash.compact!
=> nil

# Ruby dev

>> hash = { a: true, b: false, c: nil }
=> {:a=>true, :b=>false, :c=>nil}
>> hash.compact!
=> {:a=>true, :b=>false}
>> hash.compact!
=> {:a=>true, :b=>false}
>> 
~~~

@nobu Was it intentional to not return nil in case of compact! when none of the values are nil?





-- 
https://bugs.ruby-lang.org/