[ruby-core:76199] [Ruby trunk Feature#12534] Refinements: refine modules as well

[ruby-core:76199] [Ruby trunk Feature#12534] Refinements: refine modules as well

[cardoso_tiago]

Issue #12534 has been reported by Tiago Cardoso.

----------------------------------------
Feature #12534: Refinements: refine modules as well
https://bugs.ruby-lang.org/issues/12534

* Author: Tiago Cardoso
* Status: Open
* Priority: Normal
* Assignee: 
----------------------------------------
Refinements were added as a feature to scope monkey-patches on ruby core elements. This works for elements such as String, Array (all classes), but not for modules (Enumerable, Timeout...). 

This might be related to refinements not working for singleton classes (for example, I can't define a class method inside a refine block). 

This code is evaluated, but the method is undefined:

module Extension
 refine Array do
   def self.foo ; puts "bar" ; end
 end
end

This code breaks:

module Extension
 refine Kernel do
   def foo ; puts "bar" ; end
 end
end





-- 
https://bugs.ruby-lang.org/

[ruby-core:76208] [Ruby trunk Feature#12534] Refinements: refine modules as well

[shevegen]

Issue #12534 has been updated by Robert A. Heiler.


Interesting. I was not aware of this.

It is however mentioned in the documentation:

  http://ruby-doc.org/core-2.3.1/doc/syntax/refinements_rdoc.html

Quote:

"Refinements only modify classes, not modules so the argument must be a class."

As to why, I don't know either. Perhaps the documentation can add some words
to briefly state whether this is on purpose or not.

----------------------------------------
Feature #12534: Refinements: refine modules as well
https://bugs.ruby-lang.org/issues/12534#change-59424

* Author: Tiago Cardoso
* Status: Open
* Priority: Normal
* Assignee: 
----------------------------------------
Refinements were added as a feature to scope monkey-patches on ruby core elements. This works for elements such as String, Array (all classes), but not for modules (Enumerable, Timeout...). 

This might be related to refinements not working for singleton classes (for example, I can't define a class method inside a refine block). 

This code is evaluated, but the method is undefined:

module Extension
 refine Array do
   def self.foo ; puts "bar" ; end
 end
end

This code breaks:

module Extension
 refine Kernel do
   def foo ; puts "bar" ; end
 end
end





-- 
https://bugs.ruby-lang.org/

[ruby-core:76314] [Ruby trunk Feature#12534][Feedback] Refinements: refine modules as well

[shugo]

Issue #12534 has been updated by Shugo Maeda.

Status changed from Open to Feedback
Assignee set to Shugo Maeda

There is an implementation difficulty when refining modules and calling `super` in that refinement.

One solution is prohibiting `super` in a refinement for a module.
Other proposals (and patches) are welcome.


----------------------------------------
Feature #12534: Refinements: refine modules as well
https://bugs.ruby-lang.org/issues/12534#change-59550

* Author: Tiago Cardoso
* Status: Feedback
* Priority: Normal
* Assignee: Shugo Maeda
----------------------------------------
Refinements were added as a feature to scope monkey-patches on ruby core elements. This works for elements such as String, Array (all classes), but not for modules (Enumerable, Timeout...). 

This might be related to refinements not working for singleton classes (for example, I can't define a class method inside a refine block). 

This code is evaluated, but the method is undefined:

module Extension
 refine Array do
   def self.foo ; puts "bar" ; end
 end
end

This code breaks:

module Extension
 refine Kernel do
   def foo ; puts "bar" ; end
 end
end





-- 
https://bugs.ruby-lang.org/

[ruby-core:77195] [Ruby trunk Feature#12534] Refinements: refine modules as well

[matz]

Issue #12534 has been updated by Yukihiro Matsumoto.


I understand the implementation difficulty. If we prohibit `super` in refined methods in Modules, is it possible to refine modules?
If it's reasonably possible, I'd like to accept this.

Matz.


----------------------------------------
Feature #12534: Refinements: refine modules as well
https://bugs.ruby-lang.org/issues/12534#change-60410

* Author: Tiago Cardoso
* Status: Feedback
* Priority: Normal
* Assignee: Shugo Maeda
----------------------------------------
Refinements were added as a feature to scope monkey-patches on ruby core elements. This works for elements such as String, Array (all classes), but not for modules (Enumerable, Timeout...). 

This might be related to refinements not working for singleton classes (for example, I can't define a class method inside a refine block). 

This code is evaluated, but the method is undefined:

module Extension
 refine Array do
   def self.foo ; puts "bar" ; end
 end
end

This code breaks:

module Extension
 refine Kernel do
   def foo ; puts "bar" ; end
 end
end





-- 
https://bugs.ruby-lang.org/