From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (smtp.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id 6928D19E006B for ; Wed, 3 Feb 2016 19:11:08 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id 2648EB5D89D for ; Wed, 3 Feb 2016 19:45:26 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id A9FDF18CC7B6 for ; Wed, 3 Feb 2016 19:45:26 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id EC1531204E0; Wed, 3 Feb 2016 19:45:26 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o10.shared.sendgrid.net (o10.shared.sendgrid.net [173.193.132.135]) by neon.ruby-lang.org (Postfix) with ESMTPS id B8AD01204B4 for ; Wed, 3 Feb 2016 19:45:23 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=CH4c2Y+IejA5oFn5Ix9Rd502338=; b=jG5+B6wG+hJofj0pud lZGfQ3pcdSbG9P6728FDPv3Kg79W/e7WbiJietztCUV10HDvNGZPcmQhdNpTT9n4 U2ZgSCvPl+xGovJ2q7BeHUeyq6EjZbBsJtzqLLzySHo0FQnXaQrYSgKCDYLJlaQF F62MMpwFPU1NmRJAZ0zKLkgTY= Received: by filter0536p1mdw1.sendgrid.net with SMTP id filter0536p1mdw1.28894.56B1DA4035 2016-02-03 10:45:20.732452762 +0000 UTC Received: from herokuapp.com (ec2-54-90-231-137.compute-1.amazonaws.com [54.90.231.137]) by ismtpd0001p1iad1.sendgrid.net (SG) with ESMTP id iQhwJIAiSsylVfS4DQyjCg for ; Wed, 03 Feb 2016 10:45:20.739 +0000 (UTC) Date: Wed, 03 Feb 2016 10:45:20 +0000 From: usa@garbagecollect.jp To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 48272 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 11858 X-Redmine-Issue-Author: Tietew X-Redmine-Sender: usa X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS7EKbJWOkhe1KcSUce3vTI43kog0/8mGiUABn CkelZ2gvU9i1o0BCJK5a17zbNv9k1eYZgPmXtG79NoVB7rHCUcQ6pLtZD1/c8VtvgGvhDF9f1LkQ8T MsaDEcQj91BMJurSIoD5TlbUIVDON48w5O+luCnToo/t1nCTHaSnUabyzA== X-ML-Name: ruby-core X-Mail-Count: 73674 Subject: [ruby-core:73674] [Ruby trunk Bug#11858] CGI.escapeHTML should NOT return frozen string X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #11858 has been updated by Usaku NAKAMURA. Backport changed from 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN to 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: DONTNEED ---------------------------------------- Bug #11858: CGI.escapeHTML should NOT return frozen string https://bugs.ruby-lang.org/issues/11858#change-56869 * Author: Toru Iwase * Status: Closed * Priority: Normal * Assignee: * ruby -v: ruby 2.3.0dev (2015-12-22 trunk 53233) [x86_64-linux] * Backport: 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: DONTNEED ---------------------------------------- After r53220, following snippet fails. ~~~ $ ./ruby -rcgi -ve 'p CGI.escapeHTML("Hello, ".freeze) << "world."' ruby 2.3.0dev (2015-12-22 trunk 53233) [x86_64-linux] -e:1:in `
': can't modify frozen String (RuntimeError) ~~~ In preview2, works. ~~~ $ RBENV_VERSION=2.3.0-preview2 ruby -rcgi -ve 'p CGI.escapeHTML("Hello, ".freeze) << "world."' ruby 2.3.0preview2 (2015-12-11 trunk 53028) [x86_64-linux] "Hello, world." ~~~ I think this is backward incompatibility. `CGI.escapeHTML` should return different and unfreezed string from passed string as `String#gsub`. ~~~ $ ./irb ruby 2.3.0dev (2015-12-22 trunk 53233) [x86_64-linux] irb(main):001:0> str = "Ruby".freeze => "Ruby" irb(main):002:0> str.object_id => 70236871355920 irb(main):003:0> str.gsub(/\d/, '').frozen? => false irb(main):004:0> str.gsub(/\d/, '').object_id => 70236871220100 # different object irb(main):006:0> require 'cgi' => true irb(main):007:0> CGI.escapeHTML(str).frozen? => true irb(main):008:0> CGI.escapeHTML(str).object_id => 70236871355920 # same object ~~~ ---Files-------------------------------- escapehtml_dup_str.patch (2.06 KB) -- https://bugs.ruby-lang.org/