From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (smtp.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id BD92219E0058 for ; Sat, 2 Jan 2016 02:06:02 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id D9DC7B5D890 for ; Sat, 2 Jan 2016 02:38:50 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id BB19D18CC7CC for ; Sat, 2 Jan 2016 02:38:50 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 2146B120632; Sat, 2 Jan 2016 02:38:49 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o10.shared.sendgrid.net (o10.shared.sendgrid.net [173.193.132.135]) by neon.ruby-lang.org (Postfix) with ESMTPS id 2B134120616 for ; Sat, 2 Jan 2016 02:38:44 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=K59ubpVqXE2w3FZbu4/FkI4mYvA=; b=c19DLg7AEceDZqEOgC Pn7xnjUTQLNpyhGgdzy+1ypPDw0ZS1ROarKYvtDxPWFLW6f1rgZTsm1ikSySy6zr GsQqWgF+fG5chaHdDMXLSDnABuo3uSHA/SuD0uScEKANYfvynpH95Rr9/9OMsZdI 9R6uMIoMhDRsRG7Cjh5Cpx8ag= Received: by filter0537p1mdw1.sendgrid.net with SMTP id filter0537p1mdw1.28759.5686B99F25 2016-01-01 17:38:39.493833511 +0000 UTC Received: from herokuapp.com (ec2-54-242-201-206.compute-1.amazonaws.com [54.242.201.206]) by ismtpd0006p1iad1.sendgrid.net (SG) with ESMTP id PBKx4uFjRTG1WGbhywdHUg Fri, 01 Jan 2016 17:38:39.439 +0000 (UTC) Date: Fri, 01 Jan 2016 17:38:39 +0000 From: eregontp@gmail.com To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 47259 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 11901 X-Redmine-Issue-Author: amcaplan X-Redmine-Issue-Assignee: marcandre X-Redmine-Sender: Eregon X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS5IxpVJFNLuMGDzjKot2wV2UGREtf5QIn5OiQ 7BLKuuBirlh8GA2NIu54sradJcLHGiif4D3Djy6jZIb4HBUdAptYFe5WVHBDofTUTr8zJuMXtCrf2f 4pwoooXTdFcy4JK8Q3kjZPTu3cSMsyya5VQYaszlLnSxXPaIniWKB9yOiw== X-ML-Name: ruby-core X-Mail-Count: 72659 Subject: [ruby-core:72659] [Ruby trunk - Bug #11901] Performance Issue with OpenStruct X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #11901 has been updated by Benoit Daloze. Marc-Andre Lafortune wrote: > Yui NARUSE wrote: > > Could you fix rubyspec? > > Great, that was a bug > > I made an easy fix so `method_missing` doesn't add a method if frozen. I hesitated to redefine `freeze` to add all the needed method definitions, but it's difficult to know if it would be preferable. nobu did the latter in r53396. ---------------------------------------- Bug #11901: Performance Issue with OpenStruct https://bugs.ruby-lang.org/issues/11901#change-55910 * Author: Ariel Caplan * Status: Closed * Priority: Normal * Assignee: Marc-Andre Lafortune * ruby -v: ruby 2.3.0p0 (2015-12-25 revision 53290) [x86_64-darwin13] * Backport: 2.3: REQUIRED ---------------------------------------- After recent changes to define OpenStruct getter/setter methods lazily, there is a heavy performance impact for the use case where an attribute is assigned at initialization time (i.e. `Openstruct.new(foo: :bar)`). Once an attribute is stored in the internal hash, the appropriate singleton methods will never be defined, due to the recent changes to OpenStruct's `#respond_to_missing?` - meaning that every time I call `#foo` or `#foo=` it relies on `#method_missing`. Benchmark using benchmark-ips is attached. I'm primarily concerned about the case of configuration objects, which may be populated at initialization time and then accessed many times throughout the life of the program. ---Files-------------------------------- openstruct-regression-benchmark.rb (1.36 KB) -- https://bugs.ruby-lang.org/