From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (kankan.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id A46BE19E0047 for ; Fri, 1 Jan 2016 01:37:59 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id DE2BFB5D85A for ; Fri, 1 Jan 2016 02:10:44 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id B986718CC7B9 for ; Fri, 1 Jan 2016 02:10:44 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 0B13D12058E; Fri, 1 Jan 2016 02:10:42 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o10.shared.sendgrid.net (o10.shared.sendgrid.net [173.193.132.135]) by neon.ruby-lang.org (Postfix) with ESMTPS id 24C2412052A for ; Fri, 1 Jan 2016 02:10:37 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=tUuDd/ucnpe4OcYFSBTjnpAy42Y=; b=bQDGS7/v8skUQONl4g a3nx1O7h7twE9g0jmRuGUQ9EyWfhLBmF1YrO9k/o2wB4SwAcMEbrTU65AgaqLx+E S/a7x2J1gqiHCnaI4zqVOQ2Fol1BMGDwZkLZ+PSoYRl3/jTuCtbvOsSXPNUbmv7p 3PqlzS/FWjrHVAKfQpM+qhmRA= Received: by filter0593p1mdw1.sendgrid.net with SMTP id filter0593p1mdw1.7774.5685617872 2015-12-31 17:10:16.894029818 +0000 UTC Received: from herokuapp.com (ec2-54-159-162-159.compute-1.amazonaws.com [54.159.162.159]) by ismtpd0002p1iad1.sendgrid.net (SG) with ESMTP id 4c5WedpaQoq__qIO3nRNMg Thu, 31 Dec 2015 17:10:16.972 +0000 (UTC) Date: Thu, 31 Dec 2015 17:10:16 +0000 From: naruse@airemix.jp To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 47239 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 11901 X-Redmine-Issue-Author: amcaplan X-Redmine-Issue-Assignee: marcandre X-Redmine-Sender: naruse X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS6gQ96hHGwq4v1ub7GDUOao3vNCzCLYJbTlaJ VhtjR1zk74niA3B1ZypVNLOSEi9Bx74bjNhrHuUnb5eM2gjdigv2DCz2geUcoiFGainvXHY3iEDNWE iNIQxWyIRTuMgaLWPvipOqPBq5K48rlOsMf3 X-ML-Name: ruby-core X-Mail-Count: 72639 Subject: [ruby-core:72639] [Ruby trunk - Bug #11901] [Closed] Performance Issue with OpenStruct X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #11901 has been updated by Yui NARUSE. Status changed from Open to Closed Could you fix rubyspec? ---------------------------------------- Bug #11901: Performance Issue with OpenStruct https://bugs.ruby-lang.org/issues/11901#change-55890 * Author: Ariel Caplan * Status: Closed * Priority: Normal * Assignee: Marc-Andre Lafortune * ruby -v: ruby 2.3.0p0 (2015-12-25 revision 53290) [x86_64-darwin13] * Backport: 2.3: REQUIRED ---------------------------------------- After recent changes to define OpenStruct getter/setter methods lazily, there is a heavy performance impact for the use case where an attribute is assigned at initialization time (i.e. `Openstruct.new(foo: :bar)`). Once an attribute is stored in the internal hash, the appropriate singleton methods will never be defined, due to the recent changes to OpenStruct's `#respond_to_missing?` - meaning that every time I call `#foo` or `#foo=` it relies on `#method_missing`. Benchmark using benchmark-ips is attached. I'm primarily concerned about the case of configuration objects, which may be populated at initialization time and then accessed many times throughout the life of the program. ---Files-------------------------------- openstruct-regression-benchmark.rb (1.36 KB) -- https://bugs.ruby-lang.org/