From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: poffice@blade.nagaokaut.ac.jp Delivered-To: poffice@blade.nagaokaut.ac.jp Received: from kankan.nagaokaut.ac.jp (smtp.nagaokaut.ac.jp [133.44.2.24]) by blade.nagaokaut.ac.jp (Postfix) with ESMTP id F107219E0047 for ; Thu, 31 Dec 2015 14:11:12 +0900 (JST) Received: from voscc.nagaokaut.ac.jp (voscc.nagaokaut.ac.jp [133.44.1.100]) by kankan.nagaokaut.ac.jp (Postfix) with ESMTP id E1B45B5D879 for ; Thu, 31 Dec 2015 14:43:55 +0900 (JST) Received: from neon.ruby-lang.org (neon.ruby-lang.org [221.186.184.75]) by voscc.nagaokaut.ac.jp (Postfix) with ESMTP id 3C6DB18CC7B2 for ; Thu, 31 Dec 2015 14:43:56 +0900 (JST) Received: from [221.186.184.76] (localhost [IPv6:::1]) by neon.ruby-lang.org (Postfix) with ESMTP id 4605C1205B4; Thu, 31 Dec 2015 14:43:55 +0900 (JST) X-Original-To: ruby-core@ruby-lang.org Delivered-To: ruby-core@ruby-lang.org Received: from o2.heroku.sendgrid.net (o2.heroku.sendgrid.net [67.228.50.55]) by neon.ruby-lang.org (Postfix) with ESMTPS id 5B0E6120567 for ; Thu, 31 Dec 2015 14:43:52 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.me; h=from:to:references:subject:mime-version:content-type:content-transfer-encoding:list-id; s=smtpapi; bh=N1GmpZGLBxwz/+5LCKbXlzFzagk=; b=x1DRI8CoGCaDHF3ejp FHtkL2HK6o1gWsjncjuiv+YU76x3DRzVtMakVIUlxvFxLdJzAZA5SjeSHucECo5d suily1LU/fa1GWzC+wvoOYOGui2EfqliATru6uZZgdfRtOAVE4qq4BIynA8MHag5 7H8gaMZolRIDwsJ2upCJOu2dA= Received: by filter0498p1mdw1.sendgrid.net with SMTP id filter0498p1mdw1.11236.5684C09530 2015-12-31 05:43:49.571399118 +0000 UTC Received: from herokuapp.com (ec2-54-211-169-62.compute-1.amazonaws.com [54.211.169.62]) by ismtpd0002p1iad1.sendgrid.net (SG) with ESMTP id D_F21Xk3ShONZ4ZlwYQM3A Thu, 31 Dec 2015 05:43:49.628 +0000 (UTC) Date: Thu, 31 Dec 2015 05:43:49 +0000 From: ruby-core@marc-andre.ca To: ruby-core@ruby-lang.org Message-ID: References: Mime-Version: 1.0 X-Redmine-MailingListIntegration-Message-Ids: 47231 X-Redmine-Project: ruby-trunk X-Redmine-Issue-Id: 11901 X-Redmine-Issue-Author: amcaplan X-Redmine-Issue-Assignee: marcandre X-Redmine-Sender: marcandre X-Mailer: Redmine X-Redmine-Host: bugs.ruby-lang.org X-Redmine-Site: Ruby Issue Tracking System X-Auto-Response-Suppress: All Auto-Submitted: auto-generated X-SG-EID: ync6xU2WACa70kv/Ymy4QrNMhiuLXJG8OTL2vJD1yS4dmC2ZfMhxIxH65nO9SeG6jMByKvRShlqLiS Z+vi7FF3RzF1qU+UZp0EhoZvKDSWtu5sO/E4isXQKMr8T3aLvaV8lLqrkEEsc8uIOKAUjOlam5ev5f tj9UlhxnbPZGHb/lbbXYgKw0wsod/HotSIPuMOpN4SpPFnCqtECz3eh7Ug== X-ML-Name: ruby-core X-Mail-Count: 72632 Subject: [ruby-core:72632] [Ruby trunk - Bug #11901] Performance Issue with OpenStruct X-BeenThere: ruby-core@ruby-lang.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Ruby developers List-Id: Ruby developers List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ruby-core-bounces@ruby-lang.org Sender: "ruby-core" Issue #11901 has been updated by Marc-Andre Lafortune. Backport set to 2.3: REQUIRED ---------------------------------------- Bug #11901: Performance Issue with OpenStruct https://bugs.ruby-lang.org/issues/11901#change-55884 * Author: Ariel Caplan * Status: Open * Priority: Normal * Assignee: Marc-Andre Lafortune * ruby -v: ruby 2.3.0p0 (2015-12-25 revision 53290) [x86_64-darwin13] * Backport: 2.3: REQUIRED ---------------------------------------- After recent changes to define OpenStruct getter/setter methods lazily, there is a heavy performance impact for the use case where an attribute is assigned at initialization time (i.e. `Openstruct.new(foo: :bar)`). Once an attribute is stored in the internal hash, the appropriate singleton methods will never be defined, due to the recent changes to OpenStruct's `#respond_to_missing?` - meaning that every time I call `#foo` or `#foo=` it relies on `#method_missing`. Benchmark using benchmark-ips is attached. I'm primarily concerned about the case of configuration objects, which may be populated at initialization time and then accessed many times throughout the life of the program. ---Files-------------------------------- openstruct-regression-benchmark.rb (1.36 KB) -- https://bugs.ruby-lang.org/